From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>,
git@vger.kernel.org, ps@pks.im
Subject: Re: [GSoC PATCH v3 0/2] json-writer: describe the jw_* functions
Date: Fri, 16 May 2025 09:42:32 -0700 [thread overview]
Message-ID: <xmqq7c2gwlqf.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZSH4CUdAUOT7H4B+2dwgfx22wJxxjt0SqPavAnEsdkHMA@mail.gmail.com> (Karthik Nayak's message of "Fri, 16 May 2025 01:59:22 -0700")
Karthik Nayak <karthik.188@gmail.com> writes:
> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
>
>> Hello, again!
>>
>> In this v3 I did some minor adjustments based on the review of v2
>> (https://lore.kernel.org/git/20250512020935.73140-1-lucasseikioshiro@gmail.com/).
>>
>
> This version looks good to me, thanks for the update.
Yup, the result reads very well. Thanks, all.
> I do have some general suggestions (not requirements):
> - It would be nice if these patch versions were inlined with the
> previous ones. Makes it easier to compare versions while reviewing.
"git send-email --in-reply-to=..." is a good tool to use.
> - Perhaps include a range-diff to make it easier to review the changes
> in the new version compared to the last one.
Here, "git format-patch --range-diff=..." can help when preparing the
patches to be sent.
> I can totally recommend b4 (https://b4.docs.kernel.org/en/latest/), it
> helps manage both of the points I mentioned :)
... and more, by helping on the receiving end, too ;-).
prev parent reply other threads:[~2025-05-16 16:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 1:01 [GSoC PATCH v3 0/2] json-writer: describe the jw_* functions Lucas Seiki Oshiro
2025-05-16 1:01 ` [GSoC PATCH v3 1/2] json-writer: add docstrings to " Lucas Seiki Oshiro
2025-05-16 1:01 ` [GSoC PATCH v3 2/2] json-writer: describe the usage of " Lucas Seiki Oshiro
2025-05-16 8:59 ` [GSoC PATCH v3 0/2] json-writer: describe the " Karthik Nayak
2025-05-16 16:42 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7c2gwlqf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=lucasseikioshiro@gmail.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).