git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Eli Schwartz <eschwartz@gentoo.org>,
	 git@vger.kernel.org,  Peter Seiderer <ps.report@gmx.net>
Subject: Re: [PATCH 1/2] meson: report detected runtime executable paths
Date: Fri, 25 Apr 2025 09:34:53 -0700	[thread overview]
Message-ID: <xmqq7c38urma.fsf@gitster.g> (raw)
In-Reply-To: <aAsbwvtKTiZFRnXM@pks.im> (Patrick Steinhardt's message of "Fri, 25 Apr 2025 07:21:06 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> On Thu, Apr 24, 2025 at 08:45:44PM -0400, Eli Schwartz wrote:
>> On 4/24/25 9:38 AM, Patrick Steinhardt wrote:
>> > diff --git a/meson.build b/meson.build
>> > index c47cb79af08..8f04534c7ff 100644
>> > --- a/meson.build
>> > +++ b/meson.build
>> > @@ -2080,3 +2080,9 @@ summary({
>> >    'sha256': sha256_backend,
>> >    'zlib': zlib_backend,
>> >  }, section: 'Backends')
>> > +
>> > +summary({
>> > +  'perl': target_perl.found() ? target_perl.full_path() : 'none',
>> > +  'python': target_python.found() ? target_python.full_path() : 'none',
>> > +  'shell': target_shell.full_path(),
>> > +}, section: 'Runtime executable paths')
>> 
>> summary({
>>   'perl': target_perl,
>>   'python': target_python,
>>   'shell': target_shell,
>> }, section: 'Runtime executable paths')
>> 
>> 
>> No need to check if they are found. Meson will print the full_path()
>> already, if it is found, and if it is not found, it will print "NO" in
>> its standard color code (red) for things-that-are-missing.
>
> Oh, that's much nicer indeed. Thanks!

That is a lot more pleasant to the eyes.

Thanks for working well together.



  reply	other threads:[~2025-04-25 16:34 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 13:38 [PATCH 0/2] meson: prefer '/bin/sh' over PATH lookup Patrick Steinhardt
2025-04-24 13:38 ` [PATCH 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25  0:45   ` Eli Schwartz
2025-04-25  5:21     ` Patrick Steinhardt
2025-04-25 16:34       ` Junio C Hamano [this message]
2025-04-24 13:38 ` [PATCH 2/2] meson: prefer POSIX-specified shell path Patrick Steinhardt
2025-04-24 20:18   ` Justin Tobler
2025-04-25  5:21     ` Patrick Steinhardt
2025-04-24 18:28 ` [PATCH 0/2] meson: prefer '/bin/sh' over PATH lookup Junio C Hamano
2025-04-25  5:21   ` Patrick Steinhardt
2025-04-25  5:47 ` [PATCH v2 " Patrick Steinhardt
2025-04-25  5:47   ` [PATCH v2 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25  8:27     ` Toon Claes
2025-04-25  5:47   ` [PATCH v2 2/2] meson: prefer POSIX-specified shell path Patrick Steinhardt
2025-04-25  8:35     ` Toon Claes
2025-04-25 10:49     ` brian m. carlson
2025-04-25 11:52       ` Patrick Steinhardt
2025-04-25 11:24   ` [PATCH v2 0/2] meson: prefer '/bin/sh' over PATH lookup Toon Claes
2025-04-25 14:11 ` [PATCH v3 " Patrick Steinhardt
2025-04-25 14:11   ` [PATCH v3 1/2] meson: report detected runtime executable paths Patrick Steinhardt
2025-04-25 14:11   ` [PATCH v3 2/2] meson: prefer shell at "/bin/sh" Patrick Steinhardt
2025-04-25 17:04     ` Junio C Hamano
2025-04-25 18:07       ` Eli Schwartz
2025-04-25 18:51         ` Junio C Hamano
2025-04-25 22:21           ` Eli Schwartz
2025-04-25 20:10         ` brian m. carlson
2025-04-25 22:25           ` Eli Schwartz
2025-04-25 20:13     ` brian m. carlson
2025-05-02 21:16   ` [PATCH v3 0/2] meson: prefer '/bin/sh' over PATH lookup Junio C Hamano
2025-05-02 22:37     ` Eli Schwartz
2025-05-05  6:08       ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7c38urma.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=eschwartz@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=ps.report@gmx.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).