git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>,
	"Matěj Cepl" <mcepl@cepl.eu>,
	"Jonas Konrad" <jonas.konrad@uni-muenster.de>,
	git@vger.kernel.org
Subject: Re: Git branch outputs usage message on stderr
Date: Wed, 15 Jan 2025 17:21:54 -0800	[thread overview]
Message-ID: <xmqq7c6vv9hp.fsf@gitster.g> (raw)
In-Reply-To: <xmqqplknvek2.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 15 Jan 2025 15:32:29 -0800")

Junio C Hamano <gitster@pobox.com> writes:

> It is a tangent, but I wonder how many among the 40 really needed to
> use usage_with_options() to react to "-h" in the first place.  In
> other words, these manual checks for "-h" are done only because the
> code _wants_ to react to "-h" before it calls parse_options(), but
> does everybody who _wants_ to do so really _needs_ to do so?  You
> already have shown that "gir branch" did not have to, and to me, 40
> among 100+ felt way too many.

It turns out that some of the actually cannot be helped, as they do
not even use parse-options and calling usage() themselves is the
only way to show the usage text for them.

I'll send a 6-patch series out shortly.

  reply	other threads:[~2025-01-16  1:21 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-15 11:21 Git branch outputs usage message on stderr Jonas Konrad
2025-01-15 11:36 ` Matěj Cepl
2025-01-15 14:47   ` Jonas Konrad
2025-01-15 15:28   ` Junio C Hamano
2025-01-15 16:55     ` Kristoffer Haugsbakk
2025-01-15 17:14       ` Jeff King
2025-01-15 17:49         ` Junio C Hamano
2025-01-15 17:56         ` Junio C Hamano
2025-01-15 18:24           ` Jeff King
2025-01-15 21:16             ` Junio C Hamano
2025-01-15 21:29               ` Jeff King
2025-01-15 21:56                 ` Junio C Hamano
2025-01-15 22:27                   ` Jeff King
2025-01-15 23:32                     ` Junio C Hamano
2025-01-16  1:21                       ` Junio C Hamano [this message]
2025-01-16 10:24                       ` Jeff King
2025-01-15 22:11                 ` Junio C Hamano
2025-01-15 22:28                   ` Jeff King
2025-01-15 23:35                     ` Junio C Hamano
2025-01-15 18:29           ` Junio C Hamano
2025-01-15 18:33             ` Kristoffer Haugsbakk
2025-01-15 21:13               ` Junio C Hamano
2025-01-15 17:14       ` Jonas Konrad
2025-01-15 17:53         ` Kristoffer Haugsbakk
2025-01-15 17:19       ` Junio C Hamano
2025-01-15 17:39         ` Kristoffer Haugsbakk
2025-01-15 17:47           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7c6vv9hp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jonas.konrad@uni-muenster.de \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=mcepl@cepl.eu \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).