From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Patrick Steinhardt <ps@pks.im>,
git@vger.kernel.org, "D. Ben Knoble" <ben.knoble@gmail.com>
Subject: Re: [PATCH v2 2/5] ci: merge linux-gcc-default into linux-gcc
Date: Mon, 06 Jan 2025 07:51:08 -0800 [thread overview]
Message-ID: <xmqq7c780wlv.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD1ALC2f9iQady35MCdm18V3u9+b0iRhgx2Zd_UTeCY8vA@mail.gmail.com> (Christian Couder's message of "Mon, 6 Jan 2025 14:25:23 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> On Mon, Jan 6, 2025 at 8:51 AM Patrick Steinhardt <ps@pks.im> wrote:
>>
>> The "linux-gcc-default" job is mostly doing the same as the "linux-gcc"
>> job, except for a couple of minor differences:
>>
>> - We use an explicit GCC version instead of the default version
>> provided by the distribution. We have other jobs that test with
>> "gcc-8", making this distinction pointless.
>>
>> - We don't set up the Python version explicitly, and instead use the
>> default Python version. Python 2 has been end-of-life for quite a
>> while now though, making this distinction less interesting.
>>
>> - We set up the default branch name to be "main" in "linux-gcc". We
>> have other testcases that don't and also some that explicitly use
>> "master".
>>
>> So overall, the job does not add much to our test coverage. Merge it
>> into our "linux-gcc" job to reduce our test matrix a bit.
>
> I understand that the subject uses "merge" as the space is limited
> there, but it might be better to be a bit more explicit here about
> what the patch is doing, which is:
>
> - making the "linux-gcc" job use the default version of gcc provided
> by the distribution (which is ubuntu-20.04) instead of "gcc-8",
> - removing the "linux-gcc-default" job.
unify? deprecate (the 'default' one)?
FWIW, I do not think of a better way to phrase what the patch is
doing than "merge X into Y".
Thanks.
next prev parent reply other threads:[~2025-01-06 15:51 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 10:56 [PATCH 0/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 1/5] Makefile: wire up build option for deprecated features Patrick Steinhardt
2024-12-11 13:06 ` Kristoffer Haugsbakk
2024-12-13 5:26 ` Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 2/5] ci: merge linux-gcc-default into linux-gcc Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 3/5] ci: repurpose "linux-gcc" job for deprecations Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 4/5] builtin/pack-redundant: remove subcommand with breaking changes Patrick Steinhardt
2024-12-11 10:56 ` [PATCH 5/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2025-01-06 7:51 ` [PATCH v2 0/5] " Patrick Steinhardt
2025-01-06 7:51 ` [PATCH v2 1/5] Makefile: wire up build option for deprecated features Patrick Steinhardt
2025-01-06 13:20 ` Christian Couder
2025-01-06 13:20 ` Christian Couder
2025-01-06 7:51 ` [PATCH v2 2/5] ci: merge linux-gcc-default into linux-gcc Patrick Steinhardt
2025-01-06 13:25 ` Christian Couder
2025-01-06 15:51 ` Junio C Hamano [this message]
2025-01-07 12:48 ` Patrick Steinhardt
2025-01-07 13:54 ` Christian Couder
2025-01-06 7:51 ` [PATCH v2 3/5] ci: repurpose "linux-gcc" job for deprecations Patrick Steinhardt
2025-01-06 7:51 ` [PATCH v2 4/5] builtin/pack-redundant: remove subcommand with breaking changes Patrick Steinhardt
2025-01-06 7:51 ` [PATCH v2 5/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2025-01-06 13:24 ` Christian Couder
2025-01-06 15:53 ` Junio C Hamano
2025-01-07 12:48 ` Patrick Steinhardt
2025-01-07 16:40 ` Junio C Hamano
2025-01-07 16:49 ` Junio C Hamano
2025-01-07 16:55 ` rsbecker
2025-01-08 6:36 ` Patrick Steinhardt
2025-01-08 17:09 ` Junio C Hamano
2025-01-09 10:06 ` Patrick Steinhardt
2025-01-09 12:08 ` Robert Coup
2025-01-09 10:20 ` Patrick Steinhardt
2025-01-09 15:54 ` Junio C Hamano
2025-01-06 15:42 ` [PATCH v2 0/5] " Junio C Hamano
2025-01-07 12:48 ` Patrick Steinhardt
2025-01-07 16:36 ` Junio C Hamano
2025-01-20 7:42 ` [PATCH v3 " Patrick Steinhardt
2025-01-20 7:42 ` [PATCH v3 1/5] Makefile: wire up build option for deprecated features Patrick Steinhardt
2025-01-20 7:42 ` [PATCH v3 2/5] ci: merge linux-gcc-default into linux-gcc Patrick Steinhardt
2025-01-20 7:43 ` [PATCH v3 3/5] ci: repurpose "linux-gcc" job for deprecations Patrick Steinhardt
2025-01-20 7:43 ` [PATCH v3 4/5] builtin/pack-redundant: remove subcommand with breaking changes Patrick Steinhardt
2025-01-21 21:09 ` Junio C Hamano
2025-01-20 7:43 ` [PATCH v3 5/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2025-01-21 21:25 ` Junio C Hamano
2025-01-22 11:05 ` Patrick Steinhardt
2025-01-22 17:58 ` Junio C Hamano
2025-01-22 11:31 ` [PATCH v4 0/5] " Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 1/5] Makefile: wire up build option for deprecated features Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 2/5] ci: merge linux-gcc-default into linux-gcc Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 3/5] ci: repurpose "linux-gcc" job for deprecations Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 4/5] builtin/pack-redundant: remove subcommand with breaking changes Patrick Steinhardt
2025-01-22 11:31 ` [PATCH v4 5/5] remote: announce removal of "branches/" and "remotes/" Patrick Steinhardt
2025-01-22 20:32 ` Junio C Hamano
2025-02-21 15:26 ` Jakub Wilk
2025-02-21 18:30 ` Junio C Hamano
2025-02-25 7:58 ` Patrick Steinhardt
2025-02-25 23:45 ` Junio C Hamano
2025-02-26 9:21 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7c780wlv.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ben.knoble@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).