git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Extending whitespace checks
Date: Thu, 28 Nov 2024 08:53:06 +0900	[thread overview]
Message-ID: <xmqq7c8os07x.fsf@gitster.g> (raw)
In-Reply-To: <20241127150429.GD2554@coredump.intra.peff.net> (Jeff King's message of "Wed, 27 Nov 2024 10:04:29 -0500")

Jeff King <peff@peff.net> writes:

> But it seems like a very deep rabbit hole to start adding in
> shared-library line validators, because I think it ends in "now
> compile this before I agree to apply the patch".

I am not sure I understand your conclusion.  Who is telling that to
whom?  Somebody sends a patch that creates a file that requires a
special validator and the maintainer gives the validator and tells
the contributor to go use it to make sure their addition passses
before resubmitting?

I was hoping that the ability to add extra validators is more of an
enabler (than requirement and hindrance) for those who choose to be
extra careful.  It is similar to CFLAGS in our Makefile that allows
you to use options to enable more strict compiler warnings than what
other developers usually use, to notice certain class of problems
others may miss.

Shared-libraries and plug-ins remain to be solution in search of
problem at least for this project.  I do not really need CSV comma
counter, but I thought it may give a good excuse for those who want
to play with Rust and other stuff ;-)

  reply	other threads:[~2024-11-27 23:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-24  2:25 Extending whitespace checks Junio C Hamano
2024-11-24 21:41 ` Bence Ferdinandy
2024-11-24 21:58   ` Kristoffer Haugsbakk
2024-12-01  2:51     ` A bughunter
2024-11-25  3:03   ` Junio C Hamano
2024-11-25 22:04 ` Jacob Keller
2024-11-27 15:04 ` Jeff King
2024-11-27 23:53   ` Junio C Hamano [this message]
2024-12-01 22:31     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7c8os07x.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).