git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Todd Zullinger <tmz@pobox.com>,
	 Elia Pinto <gitter.spiros@gmail.com>,
	Usman Akinyemi <usmanakinyemi202@gmail.com>,
	 Andreas Schwab <schwab@linux-m68k.org>,
	 Christian Couder <christian.couder@gmail.com>,
	git@vger.kernel.org
Subject: Re: [RFC]: Test Were failing on Fedora Linux.
Date: Mon, 11 Nov 2024 12:11:46 +0900	[thread overview]
Message-ID: <xmqq7c9aihvx.fsf@gitster.g> (raw)
In-Reply-To: <20241109190012.GA588841@coredump.intra.peff.net> (Jeff King's message of "Sat, 9 Nov 2024 14:00:12 -0500")

Jeff King <peff@peff.net> writes:

> I don't offhand know of a good portable way to ask the system about
> available libraries. But I guess just doing something like:
>
>   err=$(LD_PRELOAD=libc_malloc.so.0 git version 2>&1 >/dev/null)
>   if test -z "$err"
>   then
> 	...seemed to work...
>   fi
>
> would do it?

I do not necessarily view it as "asking the system about available
libraries"; we are checking if we can sensibly run things with this
set to LD_PRELOAD.  And presumably the answer was "no" in the
original report, so it is a very direct way to ensure that we are
setting it to a sensible value.  I like it.

The above did not work for me until I did "s/malloc/&_debug/" on the
command line.  At this point in the start-up sequence in the test
framework, we should be able to run "git" from the PATH just fine,
so it would be a good way to check if we can trigger the malloc
check with the way how we expect to be able to trigger it.

Thanks.

  parent reply	other threads:[~2024-11-11  3:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09  6:01 [RFC]: Test Were failing on Fedora Linux Usman Akinyemi
2024-11-09  8:12 ` Christian Couder
2024-11-09  9:32   ` Usman Akinyemi
2024-11-09 14:01     ` Christian Couder
2024-11-09 14:35       ` Andreas Schwab
2024-11-09 15:02         ` Usman Akinyemi
2024-11-09 16:05           ` Todd Zullinger
2024-11-09 19:00             ` Jeff King
2024-11-09 19:12               ` Usman Akinyemi
2024-11-11  3:11               ` Junio C Hamano [this message]
2024-11-11  7:01                 ` [PATCH] test-lib: check malloc debug LD_PRELOAD before using Jeff King
2024-11-13 10:19                   ` Toon Claes
2024-11-14  1:27                     ` Jeff King
2024-11-14  1:39                       ` [PATCH 2/1] test-lib: move malloc-debug setup after $PATH setup Jeff King
2024-11-20 13:51                         ` Toon Claes
2024-11-20 23:26                           ` Junio C Hamano
2024-11-09 19:09             ` [RFC]: Test Were failing on Fedora Linux Usman Akinyemi
2024-11-09 14:59       ` Usman Akinyemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7c9aihvx.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian.couder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitter.spiros@gmail.com \
    --cc=peff@peff.net \
    --cc=schwab@linux-m68k.org \
    --cc=tmz@pobox.com \
    --cc=usmanakinyemi202@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).