From: Junio C Hamano <gitster@pobox.com>
To: Daniel Black <daniel@mariadb.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] submodule: correct remote name with fetch
Date: Tue, 01 Oct 2024 10:34:41 -0700 [thread overview]
Message-ID: <xmqq7carzpzi.fsf@gitster.g> (raw)
In-Reply-To: <xmqqed4zzqbg.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 01 Oct 2024 10:27:31 -0700")
Junio C Hamano <gitster@pobox.com> writes:
Sorry, forgot to say one more thing before pressing [SEND].
>> builtin/submodule--helper.c | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
Please add a test or two, that fail without this change (to
demonstrate the existing bug) and succeed with this change (to make
sure if somebody breaks the code you fixed again in the future, such
a breakage is caught).
Thanks.
next prev parent reply other threads:[~2024-10-01 17:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 11:09 bug: submodule update fails to fetch Sergei Golubchik
2023-06-22 13:07 ` Taylor Blau
2023-06-22 16:39 ` Sergei Golubchik
2023-06-23 7:26 ` Jacob Keller
2024-10-01 7:24 ` [PATCH] submodule: correct remote name with fetch Daniel Black
2024-10-01 17:27 ` Junio C Hamano
2024-10-01 17:34 ` Junio C Hamano [this message]
2024-10-08 1:49 ` Daniel Black
2024-10-08 1:49 ` [RFC PATCH v2] submodule: correct remote name with fetch Daniel Black
2024-10-08 19:23 ` Junio C Hamano
2024-10-09 3:32 ` [PATCH v3] " Daniel Black
2024-10-09 17:51 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7carzpzi.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=daniel@mariadb.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).