git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  johannes.schindelin@gmx.de,
	 Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH] scalar: add --no-tags option
Date: Thu, 05 Sep 2024 09:12:38 -0700	[thread overview]
Message-ID: <xmqq7cbq3wqx.fsf@gitster.g> (raw)
In-Reply-To: <pull.1780.git.1725545614416.gitgitgadget@gmail.com> (Derrick Stolee via GitGitGadget's message of "Thu, 05 Sep 2024 14:13:34 +0000")

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Derrick Stolee <stolee@gmail.com>
>
> Some large repositories use tags to track a huge list of release
> versions. While this is choice is costly on the ref advertisement, it is
> further wasteful for clients who do not need those tags. Allow clients
> to optionally skip the tag advertisement.
>
> This behavior is similar to that of 'git clone --no-tags' implemented in
> 0dab2468ee5 (clone: add a --no-tags option to clone without tags,
> 2017-04-26), including the modification of the remote.origin.tagOpt
> config value to include "--no-tags".
>
> One thing that is opposite of the 'git clone' implementation is that
> this allows '--tags' as an assumed option, which can be naturally negated
> with '--no-tags'. The clone command does not accept '--tags' but allows
> "--no-no-tags" as the negation of its '--no-tags' option.

Yuck.  The loophole may be something we may want to close later,
though (and replaced with a proper "--tags" support).

> While testing this option, combine the test with the previously untested
> '--no-src' option introduced in 4527db8ff8c (scalar: add --[no-]src
> option, 2023-08-28).
>
> Signed-off-by: Derrick Stolee <stolee@gmail.com>
> ---

Makes sense.

This is a tangent, but the "--[no-]tags" option in "git fetch" is
misdesigned; the default is to auto-follow tags that would annotate
objects that are being fetched, and "--no-tags" is a way to decline
the auto-following.  But "--tags" is to say that all tags must be
fetched.  There is no obvious way to say "I want the auto-following
behaviour" (e.g., to override an earlier "--no-tags" or "--tags").

  reply	other threads:[~2024-09-05 16:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-05 14:13 [PATCH] scalar: add --no-tags option Derrick Stolee via GitGitGadget
2024-09-05 16:12 ` Junio C Hamano [this message]
2024-09-05 18:25 ` Junio C Hamano
2024-09-06  7:23 ` Johannes Schindelin
2024-09-06 15:13   ` Junio C Hamano
2024-09-06 19:46     ` Derrick Stolee
2024-09-06 20:21 ` [PATCH v2] scalar: add --no-tags option to 'scalar clone' Derrick Stolee via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7cbq3wqx.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).