From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: <git@vger.kernel.org>, Jacob Keller <jacob.keller@gmail.com>,
"Konstantin Ryabitsev" <konstantin@linuxfoundation.org>
Subject: Re: [PATCH 3/3] send-email: teach git send-email option to translate aliases
Date: Fri, 09 Aug 2024 12:27:25 -0700 [thread overview]
Message-ID: <xmqq7ccpcx9e.fsf@gitster.g> (raw)
In-Reply-To: <328fb497-d16e-4af1-a816-7b4aeb531504@intel.com> (Jacob Keller's message of "Fri, 9 Aug 2024 12:12:34 -0700")
Jacob Keller <jacob.e.keller@intel.com> writes:
> Dump aliases handled this by checking @ARGV and immediately bailing if
> there were anything remaining after the call to parsing its inner
> options. This works but does not work for --translate-aliases because it
> needs to treat all the remaining arguments as aliases.
When GetOptions returns, shouldn't these "remaining arguments" be
visible in @ARGV and you can iterate over them yourself, perhaps?
next prev parent reply other threads:[~2024-08-09 19:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 21:09 [PATCH 0/3] send-email: teach git send-email mode to translate aliases Jacob Keller
2024-08-08 21:09 ` [PATCH 1/3] t90001-send-email.sh: fix quoting for mailrc --dump-aliases test Jacob Keller
2024-08-08 21:09 ` [PATCH 2/3] t9001-send-email.sh: update alias list used for pine test Jacob Keller
2024-08-08 21:10 ` [PATCH 3/3] send-email: teach git send-email option to translate aliases Jacob Keller
2024-08-08 21:57 ` Junio C Hamano
2024-08-09 19:12 ` Jacob Keller
2024-08-09 19:27 ` Junio C Hamano [this message]
2024-08-09 19:51 ` Jacob Keller
2024-08-09 21:05 ` Junio C Hamano
2024-08-10 0:29 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7ccpcx9e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=konstantin@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).