From: Junio C Hamano <gitster@pobox.com>
To: Hong Jiang <ilford@gmail.com>
Cc: Jeff King <peff@peff.net>, Bo Anderson <mail@boanderson.me>,
git@vger.kernel.org
Subject: Re: [PATCH] credential/osxkeychain: respect NUL terminator in username
Date: Thu, 01 Aug 2024 08:54:31 -0700 [thread overview]
Message-ID: <xmqq7cd0xmq0.fsf@gitster.g> (raw)
In-Reply-To: <CAEcKSiyf7JPypM93XLFJLjC1T-k9h6kushM7GqTyCBe8rico=g@mail.gmail.com> (Hong Jiang's message of "Thu, 1 Aug 2024 18:57:31 +0800")
Hong Jiang <ilford@gmail.com> writes:
> On Thu, Aug 1, 2024 at 4:25 PM Jeff King <peff@peff.net> wrote:
> ...
>> ---
>> This is not even compile tested by me! It looks like an obvious enough
>> fix, and I wanted to make sure we don't forget about it. But anybody who
>> can reproduce or test would be greatly appreciated.
> I confirm the patch works on my system.
Thanks, both. Will queue.
prev parent reply other threads:[~2024-08-01 15:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 3:41 [patch] credential-osxkeychain: Clear username_buffer before getting the converted C string Hong Jiang
2024-07-31 7:42 ` Jeff King
2024-07-31 13:07 ` Bo Anderson
2024-08-01 8:25 ` [PATCH] credential/osxkeychain: respect NUL terminator in username Jeff King
2024-08-01 10:57 ` Hong Jiang
2024-08-01 11:14 ` Jeff King
2024-08-01 15:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7cd0xmq0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ilford@gmail.com \
--cc=mail@boanderson.me \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).