From: Junio C Hamano <gitster@pobox.com>
To: Christopher Lindee <christopher.lindee@webpros.com>
Cc: "Martin Ågren" <martin.agren@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] Add transport message for up-to-date references
Date: Fri, 15 Mar 2024 09:54:38 -0700 [thread overview]
Message-ID: <xmqq7ci3saep.fsf@gitster.g> (raw)
In-Reply-To: <SA1PR14MB469168B6AAB246344190D9038D282@SA1PR14MB4691.namprd14.prod.outlook.com> (Christopher Lindee's message of "Fri, 15 Mar 2024 03:09:53 +0000")
Christopher Lindee <christopher.lindee@webpros.com> writes:
> This raises a good point: if we default to the old behavior and only
> send up-to-date refs when the new option is present (as is currently
> the case with this patchset), then existing scripts will continue to
> work. Moreover, scripts using the new option will consistently have
> "up to date", so they can change the grep to use that (since it will
> never show "Everything up-to-date!").
Scripts should never be parsing the output meant for humans. You
should worry about "git push --porcelain" output first.
I think we report "= srcref:dstref [up to date]" there and that is
what the scripts are expecting for an up-to-date case. If you want
to allow the scripts to react to a forced no-op update differently
from the normal "we didn't even tell them about this ref" case, then
we'd need a different type letter or "[up to date]" string (or
both).
prev parent reply other threads:[~2024-03-15 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 21:55 [PATCH 2/2] Add transport message for up-to-date references Christopher Lindee
2024-03-14 0:07 ` Junio C Hamano
2024-03-15 6:09 ` Christopher Lindee
2024-03-15 6:47 ` Christopher Lindee
2024-03-15 16:49 ` Junio C Hamano
2024-03-15 16:42 ` Junio C Hamano
2024-03-14 21:44 ` Martin Ågren
2024-03-15 3:09 ` Christopher Lindee
2024-03-15 16:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7ci3saep.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christopher.lindee@webpros.com \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).