From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Achu Luma <ach.lumap@gmail.com>,
git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [Outreachy][PATCH 1/2] strbuf: introduce strbuf_addstrings() to repeatedly add a string
Date: Mon, 26 Feb 2024 10:10:23 -0800 [thread overview]
Message-ID: <xmqq7cirnlkg.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD0Qhy78=v9+hCekMJPkcH2KmeZeQ0xUx8kqrByQ4PO3Xg@mail.gmail.com> (Christian Couder's message of "Mon, 26 Feb 2024 18:15:25 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> Unfortunately strbuf_add() calls strbuf_grow() itself which is not
> needed as we have already called strbuf_grow() to avoid repeated
> reallocation.
Why is it unfortunate? If the current allocation is sufficient, it
is a cheap no-op, isn't it (if not, we should make it so)?
next prev parent reply other threads:[~2024-02-26 18:10 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 14:33 [Outreachy][PATCH 1/2] strbuf: introduce strbuf_addstrings() to repeatedly add a string Achu Luma
2024-02-26 14:33 ` [Outreachy][PATCH 2/2] Port helper/test-sha256.c and helper/test-sha1.c to unit-tests/t-hash.c Achu Luma
2024-02-26 16:39 ` [Outreachy][PATCH 1/2] strbuf: introduce strbuf_addstrings() to repeatedly add a string Junio C Hamano
2024-02-26 17:15 ` Christian Couder
2024-02-26 18:10 ` Junio C Hamano [this message]
2024-02-27 10:07 ` Christian Couder
2024-02-29 5:40 ` [Outreachy][PATCH v2 " Achu Luma
2024-02-29 5:40 ` [Outreachy][PATCH v2 2/2] Port helper/test-sha256.c and helper/test-sha1.c to unit-tests/t-hash.c Achu Luma
2024-03-06 14:25 ` Christian Couder
2024-03-26 11:39 ` Patrick Steinhardt
2024-03-26 11:51 ` Christian Couder
2024-05-16 19:30 ` Ghanshyam Thakkar
2024-05-23 23:59 ` [PATCH v3 0/3] Port t0015-hash to the unit testing framework Ghanshyam Thakkar
2024-05-23 23:59 ` [PATCH v3 1/3] strbuf: introduce strbuf_addstrings() to repeatedly add a string Ghanshyam Thakkar
2024-05-23 23:59 ` [PATCH v3 2/3] t/: port helper/test-sha1.c to unit-tests/t-hash.c Ghanshyam Thakkar
2024-05-24 13:30 ` Patrick Steinhardt
2024-05-24 14:08 ` Christian Couder
2024-05-24 15:49 ` Junio C Hamano
2024-06-15 20:14 ` Ghanshyam Thakkar
2024-06-16 4:52 ` Jeff King
2024-06-17 17:44 ` Junio C Hamano
2024-06-21 18:37 ` Ghanshyam Thakkar
2024-05-23 23:59 ` [PATCH v3 3/3] t/: port helper/test-sha256.c " Ghanshyam Thakkar
2024-05-24 13:30 ` Patrick Steinhardt
2024-05-25 1:15 ` Ghanshyam Thakkar
2024-05-26 8:43 ` [PATCH v4 0/2] t/: port helper/test-{sha1, sha256} to unit-tests/t-hash Ghanshyam Thakkar
2024-05-26 8:43 ` [PATCH v4 1/2] strbuf: introduce strbuf_addstrings() to repeatedly add a string Ghanshyam Thakkar
2024-05-26 8:43 ` [PATCH v4 2/2] t/: migrate helper/test-{sha1, sha256} to unit-tests/t-hash Ghanshyam Thakkar
2024-05-29 6:26 ` Patrick Steinhardt
2024-05-29 14:54 ` Junio C Hamano
2024-05-29 8:00 ` [GSoC][PATCH v5 0/2] " Ghanshyam Thakkar
2024-05-29 8:00 ` [PATCH v5 1/2] strbuf: introduce strbuf_addstrings() to repeatedly add a string Ghanshyam Thakkar
2024-05-29 8:00 ` [PATCH v5 2/2] t/: migrate helper/test-{sha1, sha256} to unit-tests/t-hash Ghanshyam Thakkar
2024-05-29 9:19 ` [GSoC][PATCH v5 0/2] " Patrick Steinhardt
2024-05-29 16:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7cirnlkg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ach.lumap@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).