From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>, Taylor Blau <me@ttaylorr.com>
Cc: "Chen Xuewei via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, Chen Xuewei <316403398@qq.com>
Subject: Re: [PATCH] fix: platform accordance while calculating murmur3
Date: Thu, 04 Jan 2024 10:12:42 -0800 [thread overview]
Message-ID: <xmqq7ckp7ysl.fsf@gitster.g> (raw)
In-Reply-To: <pull.1636.git.git.1704376606625.gitgitgadget@gmail.com> (Chen Xuewei via GitGitGadget's message of "Thu, 04 Jan 2024 13:56:46 +0000")
"Chen Xuewei via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Chen Xuewei <316403398@qq.com>
>
> It is known that whether the highest bit is extended when char cast to
> uint32, depends on CPU architecture, which will lead different hash
> value. This is a fix to accord all architecture behaviour.
>
> Signed-off-by: Chen Xuewei <316403398@qq.com>
> ---
Jonathan and Taylor, isn't this what you two were working together
on? How would we want to proceed?
Chen, using the right implementation of the hash function to be used
after the next rebuild of the Bloom data has so far been treated as
only one part of the solution (the others include "how to deal with
the existing data? do we have a way to tell our binary to safely
ignore the Bloom data using a wrong hash?" and "how to make sure old
binaries do not get confused by the Bloom data using the right/new
hash?").
Jonathan and Taylor's (stalled) effort is here
https://lore.kernel.org/git/cover.1697653929.git.me@ttaylorr.com
Thanks.
next prev parent reply other threads:[~2024-01-04 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 13:56 [PATCH] fix: platform accordance while calculating murmur3 Chen Xuewei via GitGitGadget
2024-01-04 14:53 ` Taylor Blau
2024-01-04 18:12 ` Junio C Hamano [this message]
2024-01-04 18:27 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7ckp7ysl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=316403398@qq.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).