git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: Antonin Delpeuch <antonin@delpeuch.eu>,
	 git@vger.kernel.org,  Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH] merge-file: add --diff-algorithm option
Date: Mon, 20 Nov 2023 08:30:25 +0900	[thread overview]
Message-ID: <xmqq7cmdpbhq.fsf@gitster.g> (raw)
In-Reply-To: <de04aec0-a195-45da-8951-bb30f2a629a3@gmail.com> (Phillip Wood's message of "Sun, 19 Nov 2023 16:43:19 +0000")

Phillip Wood <phillip.wood123@gmail.com> writes:

> I can see there's an argument for changing the default algorithm of
> "git merge-file" to match what "ort" uses. I know Elijah found the
> histogram algorithm gave better results in his testing when he was
> developing "ort". While it would be a breaking change if on the
> average the new default gives better conflicts it might be worth
> it. This patch would mean that someone wanting to use the "myers"
> algorithm could still do so.

Sounds like a sensible thing to do.  First allow to configure the
custom algorithm from the command line option (and optionally via a
configuration variable) and ship it in a release, start giving a
warning if the using script did not specify the configuration or the
command line option and used the current default and ship it in the
next release, wait for a few releases and then finally flip the
default, or something like that.

Thanks.

  parent reply	other threads:[~2023-11-19 23:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-08 21:54 [PATCH] merge-file: add --diff-algorithm option Antonin Delpeuch via GitGitGadget
2023-11-17 21:42 ` Antonin Delpeuch
2023-11-19 16:43   ` Phillip Wood
2023-11-19 19:29     ` Antonin Delpeuch
2023-11-19 23:30     ` Junio C Hamano [this message]
2023-11-19 16:42 ` Phillip Wood
2023-11-20 19:18 ` [PATCH v2] " Antonin Delpeuch via GitGitGadget
2023-11-21 14:58   ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7cmdpbhq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=antonin@delpeuch.eu \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=phillip.wood123@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).