git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>,
	 Karthik Nayak <karthik.188@gmail.com>
Subject: Re: [PATCH] commit-graph: disable GIT_COMMIT_GRAPH_PARANOIA by default
Date: Wed, 15 Nov 2023 01:48:33 +0900	[thread overview]
Message-ID: <xmqq7cmkz3fi.fsf@gitster.g> (raw)
In-Reply-To: <ZVNNXNRfrwc_0Sj3@tanuki> (Patrick Steinhardt's message of "Tue, 14 Nov 2023 11:35:08 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> Gah, I forgot to run this with GIT_TEST_COMMIT_GRAPH=1 before sending
> this patch. There are two test failures that this change introduces:
>
>   - t6022-rev-list-missing.sh, where we test for the `--missing=` option
>     of git-rev-list(1).

I would have expected you to enable the paranoia mode automatically
when this option is in effect.

> Both of these are expected failures: we knowingly corrupt the repository
> and circumvent git-gc(1)/git-maintenance(1), thus no commit-graphs are
> updated. If we stick with the new stance that repository corruption
> should not require us to pessimize the common case,...

Yeah, just like we try to be extra careful while running fsck,
because "--missing" is about finding these "corrupt" cases,
triggering the paranoia mode upon seeing the option would make
sense, no?  It would fix the failure in 6022, right?

Thanks for working on this.

  parent reply	other threads:[~2023-11-14 16:48 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 10:23 [PATCH] commit-graph: disable GIT_COMMIT_GRAPH_PARANOIA by default Patrick Steinhardt
2023-11-14 10:35 ` Patrick Steinhardt
2023-11-14 14:42   ` Taylor Blau
2023-11-14 16:48   ` Junio C Hamano [this message]
2023-11-14 16:51     ` Junio C Hamano
2023-11-14 19:43       ` Jeff King
2023-11-15  0:44         ` Junio C Hamano
2023-11-15  1:36           ` Jeff King
2023-11-15 13:35         ` Patrick Steinhardt
2023-11-16  0:07           ` Junio C Hamano
2023-11-16 11:19             ` Patrick Steinhardt
2023-12-06 19:49           ` Jeff King
2023-11-20 11:01 ` [PATCH v2] " Patrick Steinhardt
2023-11-23 11:44   ` Junio C Hamano
2023-11-24 11:07     ` Patrick Steinhardt
2023-11-24 11:08 ` [PATCH v3] " Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7cmkz3fi.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).