git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Linus Arver via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Jonathan Tan <jonathantanmy@google.com>,
	 Calvin Wan <calvinwan@google.com>,
	 Linus Arver <linusa@google.com>
Subject: Re: [PATCH] strvec: drop unnecessary include of hex.h
Date: Fri, 03 Nov 2023 08:25:21 +0900	[thread overview]
Message-ID: <xmqq7cmzlov2.fsf@gitster.g> (raw)
In-Reply-To: <pull.1608.git.1698958277454.gitgitgadget@gmail.com> (Linus Arver via GitGitGadget's message of "Thu, 02 Nov 2023 20:51:17 +0000")

"Linus Arver via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Linus Arver <linusa@google.com>
>
> In 41771fa435 (cache.h: remove dependence on hex.h; make other files
> include it explicitly, 2023-02-24) we added this as part of a larger
> mechanical refactor. But strvec doesn't actually depend on hex.h, so
> remove it.
>
> Signed-off-by: Linus Arver <linusa@google.com>
> ---
>     strvec: drop unnecessary include of hex.h
>     
>     In 41771fa435 (cache.h: remove dependence on hex.h; make other files
>     include it explicitly, 2023-02-24) we added this as part of a larger
>     mechanical refactor. But strvec doesn't actually depend on hex.h, so
>     remove it.

This change somehow looks familiar.

> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1608%2Flistx%2Fstrvec-cleanup-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1608/listx/strvec-cleanup-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/1608
>
>  strvec.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/strvec.c b/strvec.c
> index 89dc9e7e753..178f4f37480 100644
> --- a/strvec.c
> +++ b/strvec.c
> @@ -1,6 +1,5 @@
>  #include "git-compat-util.h"
>  #include "strvec.h"
> -#include "hex.h"
>  #include "strbuf.h"

Makes sense.
Will queue.

Thanks.

      reply	other threads:[~2023-11-02 23:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 20:51 [PATCH] strvec: drop unnecessary include of hex.h Linus Arver via GitGitGadget
2023-11-02 23:25 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7cmzlov2.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=calvinwan@google.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jonathantanmy@google.com \
    --cc=linusa@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).