git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Han Young <hanyang.tony@bytedance.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] show doc: redirect user to git log manual instead of git diff-tree
Date: Tue, 05 Sep 2023 16:26:26 -0700	[thread overview]
Message-ID: <xmqq7cp4p5gd.fsf@gitster.g> (raw)
In-Reply-To: <20230905121219.69762-1-hanyang.tony@bytedance.com> (Han Young's message of "Tue, 5 Sep 2023 20:12:19 +0800")

Han Young <hanyang.tony@bytedance.com> writes:

> While git show accepts options that apply to the git diff-tree command,
> some options do not make sense in the context of git show.

Wow, "diff-tree" is a bit too arcane, I would agree.

Strictly speaking, "options to control how the changes are shown"
are options that are meant for "diff" command (e.g. "--stat", "-w"),
but "log" understands some of the "diff" command options, the
updated text is *not* incorrect.

Because "show" is about displaying individual commits and not range,
some options that are meant for the "log" command (e.g.
"--first-parent", "--no-merges") do not make much sense.  So

    Some options that `git log` command understands can be used to
    control how the changes the commit introduces are shown.

or something like that, perhaps?  I dunno.

> -The command takes options applicable to the 'git diff-tree' command to
> +The command takes options applicable to the 'git log' command to
>  control how the changes the commit introduces are shown.
>  
>  This manual page describes only the most frequently used options.

  reply	other threads:[~2023-09-05 23:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 12:12 [PATCH] show doc: redirect user to git log manual instead of git diff-tree Han Young
2023-09-05 23:26 ` Junio C Hamano [this message]
2023-09-06  6:09   ` Han Young
2023-09-06 17:26     ` Junio C Hamano
2023-09-20 13:27 ` [PATCH v2] " Han Young
2023-09-20 15:52   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7cp4p5gd.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hanyang.tony@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).