From: Junio C Hamano <gitster@pobox.com>
To: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1
Date: Wed, 09 Aug 2023 12:43:18 -0700 [thread overview]
Message-ID: <xmqq7cq4m27d.fsf@gitster.g> (raw)
In-Reply-To: <20230809171531.2564754-1-oswald.buddenhagen@gmx.de> (Oswald Buddenhagen's message of "Wed, 9 Aug 2023 19:15:31 +0200")
Oswald Buddenhagen <oswald.buddenhagen@gmx.de> writes:
> This was added by 3ece9bf0f9 (send-email: clear the $message_id after
> validation, 2023-05-17) for no apparent reason, as this is required only
> in cases when git's stdin is (must be) redirected, which isn't the case
> here.
>
> Signed-off-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Good eyes. Thanks, will apply.
>
> ---
> Cc: Junio C Hamano <gitster@pobox.com>
> ---
> t/t9001-send-email.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh
> index 48bf0af2ee..c445859f73 100755
> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -659,7 +659,6 @@ test_expect_success $PREREQ 'clear message-id before parsing a new message' '
> clean_fake_sendmail &&
> echo true | write_script my-hooks/sendemail-validate &&
> test_config core.hooksPath my-hooks &&
> - GIT_SEND_EMAIL_NOTTY=1 \
> git send-email --validate --to=recipient@example.com \
> --smtp-server="$(pwd)/fake.sendmail" \
> $patches $threaded_patches &&
prev parent reply other threads:[~2023-08-09 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 17:15 [PATCH] t9001: remove excessive GIT_SEND_EMAIL_NOTTY=1 Oswald Buddenhagen
2023-08-09 19:43 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7cq4m27d.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=oswald.buddenhagen@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).