From: Junio C Hamano <gitster@pobox.com>
To: Rupinderjeet Singh <rupinderjeet47@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [suggestion] Fail cherry-pick if it overwrites untracked files with the matching file names
Date: Sat, 15 Oct 2022 11:35:32 -0700 [thread overview]
Message-ID: <xmqq7d11540b.fsf@gitster.g> (raw)
In-Reply-To: <CAAheMRzYX6PdWMtcB=px_kD=-gnGGHvDgvR6Jxy94JH2DpYpJw@mail.gmail.com> (Rupinderjeet Singh's message of "Sat, 15 Oct 2022 23:39:34 +0530")
If the situation is about cherry-picking a commit that adds a new
file F to a checkout of another commit that lacks the file F, I
think the command is working exactly as designed.
$ git init
$ git commit -m 'initial' --allow-empty
$ git tag initial
$ date >file
$ git add file
$ git commit -m 'add file'
$ git tag added
$ git checkout -b second initial
... at this point we are back to the original state
... without 'file'
$ >file
... the file is untracked with precious contents
... and the presence of it stops a cherry-pick that clobbers it
$ git cherry-pick added
error: The following untracked working tree files would be overwritten by merge:
file
Please move or remove them before you merge.
Aborting
fatal: cherry-pick failed
Now continuing from the above, things get (slightly) interesting
$ echo file >.gitignore
$ git cherry-pick added
This will replace "file" with the one from the "added" commit, and
that is because the user marked that the "file" in the working tree
is expendable.
Files in a working tree controlled by git fall into one of three
classes. Tracked files are those that are known to the index and
appear in "git ls-files" output. Among the others, ignored files
are those that .gitignore mechanism says are expendable. The rest
are "untracked", possibly containing valuable contents that should
not be lost as the user may choose to 'git add' them later.
Not just cherry-pick but any merge-related operations, including
"checkout", follow this semantics. Untracked files are kept, but
ignored files are expendable and will be removed if they are in the
way to complete the operation the user asks.
$ rm .gitignore
$ git checkout master
error: The following untracked working tree files would be overwritten by checkout:
file
Please move or remove them before you switch branches.
Aborting
$ echo file >.gitignore
$ git checkout master
... this should succeed, removing "file" whose contents were
... marked expendable.
Of course, after switching to 'master' (or cherry-picking 'added'),
the project now cares about the 'file'. After all, it bothered to
add it to keep track of the changes to its contents. So it is
recommended that you would adjust the contents of .gitignore so that
it no longer is marked as expendable.
next prev parent reply other threads:[~2022-10-15 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 18:09 [suggestion] Fail cherry-pick if it overwrites untracked files with the matching file names Rupinderjeet Singh
2022-10-15 18:33 ` Junio C Hamano
2022-10-15 18:35 ` Junio C Hamano [this message]
2022-10-15 19:09 ` Rupinderjeet Singh
2022-10-16 17:08 ` Junio C Hamano
2022-10-16 2:07 ` Elijah Newren
2022-10-16 16:57 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7d11540b.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=rupinderjeet47@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).