From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CC66C43334 for ; Tue, 19 Jul 2022 22:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239213AbiGSWUp (ORCPT ); Tue, 19 Jul 2022 18:20:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238865AbiGSWUn (ORCPT ); Tue, 19 Jul 2022 18:20:43 -0400 Received: from pb-smtp2.pobox.com (pb-smtp2.pobox.com [64.147.108.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBBD53FA22 for ; Tue, 19 Jul 2022 15:20:41 -0700 (PDT) Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 0850C127A31; Tue, 19 Jul 2022 18:20:41 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=6tFwX56dl3GL O6jkQZlfkg3qQ4I4XxdVHBqQqqanR4A=; b=xyzJbtZEDXYFm197k06kuiPvUt4s XMiQpySJnFimQHCDH6/CGFBT68dICgoh4jyfrLkY7Y3sPliXjV+VpCf+MhfOIm88 vGNu01lZK1oxKG01ldXmbW+OznB2u0zzRqtedEWvjIX3tdCjVltAwJveeMgsbNjK XuxmvTP/IU7j/hk= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 00F22127A30; Tue, 19 Jul 2022 18:20:41 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.92.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 5FFBA127A2B; Tue, 19 Jul 2022 18:20:40 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org Subject: Re: [PATCH] repack: document there is no need to avoid delta-base-offset References: <220716.8635f1zdg3.gmgdl@evledraar.gmail.com> <220718.86tu7eyhvz.gmgdl@evledraar.gmail.com> <220719.8635exwje8.gmgdl@evledraar.gmail.com> <220719.86h73cvkbw.gmgdl@evledraar.gmail.com> Date: Tue, 19 Jul 2022 15:20:39 -0700 In-Reply-To: <220719.86h73cvkbw.gmgdl@evledraar.gmail.com> (=?utf-8?B?IsOG?= =?utf-8?B?dmFyIEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Tue, 19 Jul 2022 23:54:18 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: 05ABAC32-07B1-11ED-BE92-CB998F0A682E-77302942!pb-smtp2.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > On Tue, Jul 19 2022, Junio C Hamano wrote: > >> As continued use of 1.4.4 by people stopped being an issue long time >> ago, we can safely remove the warning about interoperability that we >> added in 1.6.0 when the use of delta-base-offset has become default. >> >> Signed-off-by: Junio C Hamano >> --- >> >> * Instead of outright removing, it probably is a good idea to hint >> the reason why the now seemingly useless configuration variable >> is there, perhaps. > > We cover that in git-config(1), I don't see a reason to continue > dicsussing it in git-repack(1) as well. Just above the paragraph you're > modifying we link to it. > > The patch you've got here also replaces a specific reason (pre-1.4.4) > with a vague reference to "hardly any reason", leaving the reader > wondering what that reason is... Yup, that is the effect I exactly wanted to have, with the "hint". If you are curious, you'd dig. If not, you can just trust the documentation and not worry about it ;-)