From: Junio C Hamano <gitster@pobox.com>
To: Florian Mickler <florian@mickler.org>
Cc: git@vger.kernel.org, jqassar@gmail.com
Subject: Re: passing CURLOPT_CERTTYPE to libcurl
Date: Fri, 17 Dec 2021 17:08:59 -0800 [thread overview]
Message-ID: <xmqq7dc2zplg.fsf@gitster.g> (raw)
In-Reply-To: <20211218010621.2fdc2b3c@monster.mickler.org> (Florian Mickler's message of "Sat, 18 Dec 2021 01:06:21 +0100")
Florian Mickler <florian@mickler.org> writes:
> Is there a specific reason, that patch wasn't merged? It would allow
> for non-pem ssl certificates to be loaded also (without pkcs11 at all).
>
> I realize, that the underlying systems could and should set up
> everything automagically as soon as i point them to the certificate that
> i want to use. But not opening up these CURL Settings from git seems
> kind of silly given that today's systems still seem kinda borked and do
> not do that. What harm comes from these two tuning knobs being exposed?
>
> Best regards,
> Flo
>
>
> [1] https://marc.info/?l=git&m=136675822032549&w=2
Almost always, when some patch aims to achieve a worthy goal, and in
the initial discussion on the thread more experienced project
members agree it is a worthwhile thing to do, the only reason why
the feature proposed does not materialize in later versions of Git
is because the developer with the original itch did not follow it
through after getting review comments and saying something that
makes reviewers to expect an updated version of the patch.
I didn't follow your marc.info URL, but I am reasonably sure, if I
were involved in the discussion, that would be the likely reason.
next prev parent reply other threads:[~2021-12-18 1:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-18 0:06 passing CURLOPT_CERTTYPE to libcurl Florian Mickler
2021-12-18 1:08 ` Junio C Hamano [this message]
2021-12-20 22:21 ` Johannes Schindelin
2021-12-21 9:45 ` Florian Mickler
2021-12-21 16:20 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7dc2zplg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=florian@mickler.org \
--cc=git@vger.kernel.org \
--cc=jqassar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).