git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Saksham Mittal <gotlouemail@gmail.com>
Cc: Johannes Altmanninger <aclopte@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code
Date: Sat, 13 Nov 2021 22:41:13 -0800	[thread overview]
Message-ID: <xmqq7ddbme7q.fsf@gitster.g> (raw)
In-Reply-To: <2b2386b9-045d-a0b8-6dbc-8a9d0c446bea@gmail.com> (Saksham Mittal's message of "Sat, 13 Nov 2021 18:38:25 +0530")

Saksham Mittal <gotlouemail@gmail.com> writes:

>> It is declared, there is an "int i;" a few lines up.
>
> Oh, man, I never even saw that! The patch is completely unnecessary
> then. Sorry for that!

No need to say sorry; you'd want to be a bit more careful next time,
that's all.

Also, our code does not introduce a new variable in the first part
of "for (;;)" loop control, so even if the original lacked decl for
"i", the posted patch is not how we write our code for this project.

Thanks.


  reply	other threads:[~2021-11-14  6:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13 12:28 [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code Saksham Mittal
2021-11-13 13:05 ` Johannes Altmanninger
2021-11-13 13:08   ` Saksham Mittal
2021-11-14  6:41     ` Junio C Hamano [this message]
2021-11-14 14:28       ` Is 'for (int i = [...]' bad for C STD compliance reasons? (was: [PATCH] MyFirstContribution.txt: fix undeclared variable i in sample code) Ævar Arnfjörð Bjarmason
2021-11-14 18:03         ` Is 'for (int i = [...]' bad for C STD compliance reasons? Junio C Hamano
2021-11-14 18:25           ` Ævar Arnfjörð Bjarmason
2021-11-14 18:57             ` brian m. carlson
2021-11-14 19:33               ` Carlo Arenas
2021-11-14 19:01             ` Carlo Arenas
2021-11-15  6:27           ` [PATCH] revision: use C99 declaration of variable in for() loop Junio C Hamano
2021-11-15  7:44             ` Martin Ågren
2021-11-16  8:29               ` Junio C Hamano
2021-11-15 22:26             ` brian m. carlson
2021-11-17 11:03             ` Phillip Wood
2021-11-17 12:39               ` Ævar Arnfjörð Bjarmason
2021-11-17 22:30               ` SZEDER Gábor
2021-11-18  7:09               ` Junio C Hamano
2021-12-07 11:10                 ` Phillip Wood
2021-12-07 20:37                   ` Junio C Hamano
2021-12-08 12:17                 ` Removing -Wdeclaration-after-statement (was: [PATCH] revision: use C99 declaration of variable in for() loop) Ævar Arnfjörð Bjarmason
2021-12-08 17:05                   ` Removing -Wdeclaration-after-statement Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7ddbme7q.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=aclopte@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gotlouemail@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).