From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org, matheus.bernardino@usp.br,
steadmon@google.com, emilyshaffer@google.com
Subject: Re: What's cooking in git.git (Aug 2021, #08; Mon, 23)
Date: Tue, 24 Aug 2021 17:15:11 -0700 [thread overview]
Message-ID: <xmqq7dgal6r4.fsf@gitster.g> (raw)
In-Reply-To: <20210824175105.200959-1-jonathantanmy@google.com> (Jonathan Tan's message of "Tue, 24 Aug 2021 10:51:05 -0700")
Jonathan Tan <jonathantanmy@google.com> writes:
>> * jt/grep-wo-submodule-odb-as-alternate (2021-08-13) 8 commits
>> - t7814: show lack of alternate ODB-adding
>> - submodule-config: pass repo upon blob config read
>> - grep: add repository to OID grep sources
>> - grep: allocate subrepos on heap
>> - grep: read submodule entry with explicit repo
>> - grep: typesafe versions of grep_source_init
>> - grep: use submodule-ODB-as-alternate lazy-addition
>> - submodule: lazily add submodule ODBs as alternates
>>
>> The code to make "git grep" recurse into submodules has been
>> updated to migrate away from the "add submodule's object store as
>> an alternate object store" mechanism (which is suboptimal).
>
> For what it's worth, Emily Shaffer [1], Josh Steadmon [2], and Matheus
> Tavares [3] have reviewed this patch set.
>
> [1] Reviewed-bys in reply to the patches in
> https://lore.kernel.org/git/cover.1628618950.git.jonathantanmy@google.com/
> except for patch 6
> [2] https://lore.kernel.org/git/YRRT4I3MPoZXJZEl@google.com/
> [3] https://lore.kernel.org/git/CAHd-oW6Va31PaTQeoSrwi09wjHk63S-Xd_PYtW1trhSokoKizQ@mail.gmail.com/
Thanks.
next prev parent reply other threads:[~2021-08-25 0:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 21:39 What's cooking in git.git (Aug 2021, #08; Mon, 23) Junio C Hamano
2021-08-24 10:08 ` Ævar Arnfjörð Bjarmason
2021-08-25 0:09 ` Junio C Hamano
2021-08-24 17:51 ` Jonathan Tan
2021-08-25 0:15 ` Junio C Hamano [this message]
2021-08-27 10:32 ` lilinchao
2021-08-27 16:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7dgal6r4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=matheus.bernardino@usp.br \
--cc=steadmon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).