From: Junio C Hamano <gitster@pobox.com>
To: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] ci: use upload-artifacts v1 for dockerized jobs
Date: Thu, 12 Aug 2021 12:59:21 -0700 [thread overview]
Message-ID: <xmqq7dgq304m.fsf@gitster.g> (raw)
In-Reply-To: <20210812065234.71399-1-carenas@gmail.com> ("Carlo Marcelo Arenas Belón"'s message of "Wed, 11 Aug 2021 23:52:34 -0700")
Carlo Marcelo Arenas Belón <carenas@gmail.com> writes:
> e9f79acb28 (ci: upgrade to using actions/{up,down}load-artifacts v2,
> 2021-06-23) changed all calls to that action from v1 to v2, but there
> is still an open bug[1] that affects all nodejs actions and prevents
> its use in 32-bit linux (as used by the Linux32 container)
>
> move all dockerized jobs to use v1 that was build in C# and therefore
"was build -> was built", I would think.
> doesn't have this problem which will otherwise manifest with confusing
> messages like:
>
> /usr/bin/docker exec 0285adacc4536b7cd962079c46f85fa05a71e66d7905b5e4b9b1a0e8b305722a sh -c "cat /etc/*release | grep ^ID"
> OCI runtime exec failed: exec failed: container_linux.go:380: starting container process caused: no such file or directory: unknown
>
> [1] https://github.com/actions/runner/issues/1011
> ---
Not signed off.
> .github/workflows/main.yml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 47876a4f02..9dd41a1742 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -258,7 +258,7 @@ jobs:
> - jobname: linux-musl
> image: alpine
> - jobname: Linux32
> - image: daald/ubuntu32:xenial
> + image: i386/ubuntu:xenial
Intended or accidental? At least it is not explained where this
change comes from in the proposed log message.
> env:
> jobname: ${{matrix.vector.jobname}}
> runs-on: ubuntu-latest
> @@ -271,7 +271,7 @@ jobs:
> if: failure()
> - name: Upload failed tests' directories
> if: failure() && env.FAILED_TEST_ARTIFACTS != ''
> - uses: actions/upload-artifact@v2
> + uses: actions/upload-artifact@v1
This one matches what the proposed log message says, switching from
@v2 to @v1.
> with:
> name: failed-tests-${{matrix.vector.jobname}}
> path: ${{env.FAILED_TEST_ARTIFACTS}}
next prev parent reply other threads:[~2021-08-12 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 6:52 [PATCH] ci: use upload-artifacts v1 for dockerized jobs Carlo Marcelo Arenas Belón
2021-08-12 19:59 ` Junio C Hamano [this message]
2021-08-12 22:19 ` Carlo Arenas
2021-08-13 6:28 ` Junio C Hamano
2021-08-13 9:13 ` [PATCH v2] " Carlo Marcelo Arenas Belón
2021-08-14 22:17 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7dgq304m.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).