From: Junio C Hamano <gitster@pobox.com>
To: Emily Shaffer <emilyshaffer@google.com>
Cc: Heba Waly via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Heba Waly <heba.waly@gmail.com>
Subject: Re: [PATCH v2 0/1] [Outreachy] commit: display advice hints when commit fails
Date: Thu, 19 Dec 2019 11:23:54 -0800 [thread overview]
Message-ID: <xmqq7e2sazlh.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191219185427.GA227872@google.com> (Emily Shaffer's message of "Thu, 19 Dec 2019 10:54:27 -0800")
Emily Shaffer <emilyshaffer@google.com> writes:
> On Thu, Dec 19, 2019 at 10:26:40AM -0800, Junio C Hamano wrote:
>> "Heba Waly via GitGitGadget" <gitgitgadget@gmail.com> writes:
>>
>> > @@ -19,16 +19,16 @@
>> > # (use "git add <file>..." to update what will be committed)
>> > # (use "git checkout -- <file>..." to discard changes in working directory)
>> > #
>> > - # modified: ../builtin/commit.c
>> > + # modified: /builtin/commit.c
>>
>> Really?
>
> It's hard to know what this cryptic comment means.. :)
>
> This was a recommended change:
> https://lore.kernel.org/git/20191218031338.203382-1-jonathantanmy@google.com
>
> Since other changes were being made at the same time, I personally don't
> mind a little nit fix in the commit message.
>
> Or, do you mean that "now it looks like the file is at the filesystem
> root, which is wrong"? It is indeed wrong now when it wasn't before. But
> I, for one, can't tell what you mean by just the one word.
That is exactly the point. I am not in the business of spoon
feeding answers. I want my contributors to *think*.
next prev parent reply other threads:[~2019-12-19 19:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 9:17 [PATCH 0/1] [Outreachy] commit: display advice hints when commit fails Heba Waly via GitGitGadget
2019-12-17 9:17 ` [PATCH 1/1] " Heba Waly via GitGitGadget
2019-12-17 22:41 ` Junio C Hamano
2019-12-17 22:45 ` Emily Shaffer
2019-12-19 3:47 ` Heba Waly
2019-12-18 3:13 ` Jonathan Tan
2019-12-18 18:14 ` Junio C Hamano
2019-12-19 3:48 ` Heba Waly
2019-12-19 9:16 ` [PATCH v2 0/1] [Outreachy] " Heba Waly via GitGitGadget
2019-12-19 9:16 ` [PATCH v2 1/1] " Heba Waly via GitGitGadget
2019-12-19 19:14 ` Junio C Hamano
2019-12-19 19:22 ` Junio C Hamano
2019-12-19 19:47 ` Eric Sunshine
2019-12-19 19:57 ` Junio C Hamano
2019-12-20 2:31 ` Emily Shaffer
2019-12-20 18:34 ` Junio C Hamano
2019-12-20 21:39 ` Emily Shaffer
2019-12-31 0:04 ` Jonathan Tan
2019-12-31 19:06 ` Junio C Hamano
2020-01-02 19:56 ` Jonathan Tan
2019-12-19 18:26 ` [PATCH v2 0/1] [Outreachy] " Junio C Hamano
2019-12-19 18:54 ` Emily Shaffer
2019-12-19 19:23 ` Junio C Hamano [this message]
2019-12-19 19:45 ` Junio C Hamano
2019-12-21 4:37 ` Heba Waly
2019-12-21 23:54 ` Junio C Hamano
2019-12-21 5:02 ` Heba Waly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7e2sazlh.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=emilyshaffer@google.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=heba.waly@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).