git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Mihail Atanassov <m.atanassov92@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Documentation/git-bisect.txt: add --no-ff to merge command
Date: Tue, 29 Oct 2019 12:25:43 +0900	[thread overview]
Message-ID: <xmqq7e4o6xmw.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqq4kzs8f1l.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Tue, 29 Oct 2019 11:24:22 +0900")

Junio C Hamano <gitster@pobox.com> writes:

> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> As an orthogonal point, I wonder whether we can start the multi-step
>> migration of making --no-commit imply --no-ff by default:
>>
>>  1. Act as --ff when --no-commit is passed without --ff or --no-ff
>>     (the state today)
>
> which means "--no-commit controls whether a new commit is created or
> not and nothing else, and because --ff is the default for merge,
> merging a true descendant will fast-forward".
>
>>  5. Refuse to perform a fast-forward merge with --no-commit is passed
>>     without --ff or --no-ff, just as though --no-ff were passed.
>
> Is that a good endgame, though?

Ah, I was confused by "refuse to perform".  You were not trying to
make the command fail outright without doing anything.  Yes, that
would be a good endgame, I would think.

I am not sure if the transition would be smooth, though.

      reply	other threads:[~2019-10-29  3:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 22:20 [PATCH] Documentation/git-bisect.txt: add --no-ff to merge command Mihail Atanassov
2019-10-26  2:26 ` Jonathan Nieder
     [not found]   ` <CALs020+0E=7wy-N46BRLrBcKmMSTpcMyZ9WybmgTzb60aCo5PQ@mail.gmail.com>
2019-10-28 22:10     ` Mihail Atanassov
2019-10-28 22:24       ` Jonathan Nieder
2019-10-29  2:24         ` Junio C Hamano
2019-10-29  3:25           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7e4o6xmw.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=m.atanassov92@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).