git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: pw/rebase-x-sanity-check, was Re: What's cooking in git.git (Jan 2019, #04; Mon, 28)
Date: Tue, 29 Jan 2019 10:11:05 -0800	[thread overview]
Message-ID: <xmqq7een8hc6.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1901291353340.41@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Tue, 29 Jan 2019 13:54:55 +0100 (STD)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

> On Mon, 28 Jan 2019, Junio C Hamano wrote:
>
>> * pw/rebase-x-sanity-check (2019-01-28) 1 commit
>>  - rebase -x: sanity check command
>> 
>>  "git rebase -x $cmd" did not reject multi-line command, even though
>>  the command is incapable of handling such a command.  It now is
>>  rejected upfront.
>> 
>>  Will merge to 'next'.
>
> I offered two suggestions: to use a more readable `strchr()` check for the
> forbidden embedded newlines, and to not bother with special-casing the
> empty command but instead handling it the exact same way as an invalid
> command-line would be handled.

Thanks for stopping me with a prompt response.



  reply	other threads:[~2019-01-29 18:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28 22:43 What's cooking in git.git (Jan 2019, #04; Mon, 28) Junio C Hamano
2019-01-29  7:22 ` Torsten Bögershausen
2019-01-29 12:54 ` pw/rebase-x-sanity-check, was " Johannes Schindelin
2019-01-29 18:11   ` Junio C Hamano [this message]
2019-01-29 14:03 ` js/rebase-am, " Johannes Schindelin
2019-01-29 14:06 ` tt/bisect-in-c, " Johannes Schindelin
2019-01-29 15:39   ` Johannes Schindelin
2019-01-29 14:15 ` en/rebase-merge-on-sequencer, " Johannes Schindelin
2019-01-29 14:21 ` Johannes Schindelin
2019-01-29 14:23 ` ps/stash-in-c, was " Johannes Schindelin
2019-01-29 14:26 ` [PATCH] Fix typos in whats-cooking.txt, " Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq7een8hc6.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).