From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/5] builtin/config.c: support `--type=<type>` as preferred alias for `--type`
Date: Thu, 26 Apr 2018 14:25:44 +0900 [thread overview]
Message-ID: <xmqq7eou35ev.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <1bc42a611089a2552b1d8bc83ff229be0a5136ff.1524716420.git.me@ttaylorr.com> (Taylor Blau's message of "Wed, 25 Apr 2018 21:25:22 -0700")
Taylor Blau <me@ttaylorr.com> writes:
> Subject: Re: [PATCH 2/5] builtin/config.c: support `--type=<type>` as preferred alias for `--type`
I'd retitle while queuing, as the last 'type' is a placeholder for
concrete types like <type> above.
> +static int option_parse_type(const struct option *opt, const char *arg,
> + int unset)
> +{
> + int new_type;
> + int *to_type;
Splitting these into two lines (unlike placing on a single same
line, which was how the previous round was queued) like this is
good.
> +...
> + new_type = opt->defval;
> + if (!new_type) {
> +...
> + }
> +
> + *to_type = opt->value;
But this is wrong, no? You meant opt->value points at an integer
variable that receives the type we discover by parsing, i.e.
to_type = opt->value;
next prev parent reply other threads:[~2018-04-26 5:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-26 4:25 [PATCH 0/5] builtin/config.c: combined series '--type', '--default' Taylor Blau
2018-04-26 4:25 ` [PATCH 1/5] builtin/config.c: treat type specifiers singularly Taylor Blau
2018-04-26 4:25 ` [PATCH 2/5] builtin/config.c: support `--type=<type>` as preferred alias for `--type` Taylor Blau
2018-04-26 5:25 ` Junio C Hamano [this message]
2018-04-26 6:00 ` Taylor Blau
2018-04-27 6:06 ` Eric Sunshine
2018-04-26 4:25 ` [PATCH 3/5] builtin/config: introduce `--default` Taylor Blau
2018-04-26 4:25 ` [PATCH 4/5] config.c: introduce 'git_config_color' to parse ANSI colors Taylor Blau
2018-04-26 4:25 ` [PATCH 5/5] builtin/config: introduce `color` type specifier Taylor Blau
2018-04-26 5:32 ` Junio C Hamano
2018-04-26 6:01 ` Taylor Blau
2018-04-26 5:58 ` [PATCH v2 0/5] builtin/config.c: combined series '--type', '--default' Taylor Blau
2018-04-26 5:58 ` [PATCH v2 1/5] builtin/config.c: treat type specifiers singularly Taylor Blau
2018-04-26 5:58 ` [PATCH v2 2/5] builtin/config.c: support `--type=<type>` as preferred alias for `--<type>` Taylor Blau
2018-04-26 9:49 ` Junio C Hamano
2018-04-27 5:57 ` Eric Sunshine
2018-04-26 5:58 ` [PATCH v2 3/5] builtin/config: introduce `--default` Taylor Blau
2018-04-26 5:58 ` [PATCH v2 4/5] config.c: introduce 'git_config_color' to parse ANSI colors Taylor Blau
2018-04-26 5:58 ` [PATCH v2 5/5] builtin/config: introduce `color` type specifier Taylor Blau
2018-04-27 6:22 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7eou35ev.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).