From: Junio C Hamano <gitster@pobox.com>
To: Ben Peart <benpeart@microsoft.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v1] fsmonitor: update documentation to remove reference to invalid config settings
Date: Wed, 14 Feb 2018 10:28:08 -0800 [thread overview]
Message-ID: <xmqq7erfo287.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180214154130.111708-1-benpeart@microsoft.com> (Ben Peart's message of "Wed, 14 Feb 2018 10:41:30 -0500")
Ben Peart <benpeart@microsoft.com> writes:
> Remove the reference to setting core.fsmonitor to `true` (or `false`) as those
> are not valid settings.
>
> Signed-off-by: Ben Peart <benpeart@microsoft.com>
> ---
Thanks. It is a bit embarrassing that nobody caught it for this
long. Will apply.
>
> Notes:
> Base Ref: master
> Web-Diff: https://github.com/benpeart/git/commit/4b7ec2c11e
> Checkout: git fetch https://github.com/benpeart/git fsmonitor_docs-v1 && git checkout 4b7ec2c11e
>
> Documentation/git-update-index.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt
> index bdb0342593..ad2383d7ed 100644
> --- a/Documentation/git-update-index.txt
> +++ b/Documentation/git-update-index.txt
> @@ -484,8 +484,8 @@ the `core.fsmonitor` configuration variable (see
> linkgit:git-config[1]) than using the `--fsmonitor` option to
> `git update-index` in each repository, especially if you want to do so
> across all repositories you use, because you can set the configuration
> -variable to `true` (or `false`) in your `$HOME/.gitconfig` just once
> -and have it affect all repositories you touch.
> +variable in your `$HOME/.gitconfig` just once and have it affect all
> +repositories you touch.
>
> When the `core.fsmonitor` configuration variable is changed, the
> file system monitor is added to or removed from the index the next time
>
> base-commit: e7e80778e705ea3f9332c634781d6d0f8c6eab64
prev parent reply other threads:[~2018-02-14 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 15:41 [PATCH v1] fsmonitor: update documentation to remove reference to invalid config settings Ben Peart
2018-02-14 18:28 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7erfo287.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=benpeart@microsoft.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).