From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: Duy Nguyen <pclouds@gmail.com>,
Brandon Williams <bmwill@google.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 0/2] improve relocate_git_dir to fail into a sane state.
Date: Mon, 19 Dec 2016 15:27:09 -0800 [thread overview]
Message-ID: <xmqq7f6vmrea.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAGZ79kZA1HxsdCAQxKiNMQrH9fLrhGKc8Um7x-R7u92ujVBigQ@mail.gmail.com> (Stefan Beller's message of "Mon, 19 Dec 2016 15:14:49 -0800")
Stefan Beller <sbeller@google.com> writes:
> On Mon, Dec 19, 2016 at 2:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Stefan Beller <sbeller@google.com> writes:
>>
>>> This goes on top of sb/submodule-embed-gitdir.
>>> When the absorbing of a git dir fails, try to recover into a sane state,
>>> i.e. try to undo the move of the git dir.
>>
>> Are these unconditionally good improvements? I ask because the
>> series is still not in 'next' and it is the last chance to fold
>> these into existing patches if we wanted to.
>
> Actually I forgot to mark these as RFC-ish as it is a response to
> https://public-inbox.org/git/20161219053507.GA2335@duynguyen.vn.dektech.internal/
> (which was the only review comment this round)
>
> So I'd say these patches are rather experimental in my mind
> unlike the absorb series, which I assume is ok as is already.
OK. Thanks for clarification.
prev parent reply other threads:[~2016-12-19 23:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 21:57 [PATCH 0/2] improve relocate_git_dir to fail into a sane state Stefan Beller
2016-12-19 21:57 ` [PATCH 1/2] dir.c: split up connect_work_tree_and_git_dir Stefan Beller
2016-12-19 21:57 ` [PATCH 2/2] dir.c: add retry logic to relocate_gitdir Stefan Beller
2016-12-19 22:25 ` Brandon Williams
2016-12-19 23:19 ` Stefan Beller
2017-01-04 13:34 ` Duy Nguyen
2016-12-19 22:54 ` [PATCH 0/2] improve relocate_git_dir to fail into a sane state Junio C Hamano
2016-12-19 23:14 ` Stefan Beller
2016-12-19 23:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7f6vmrea.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).