From: Junio C Hamano <gitster@pobox.com>
To: Ralf Thielow <ralf.thielow@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH] sequencer.c: abbreviate hashs placed in the middle of messages
Date: Fri, 08 May 2015 10:31:32 -0700 [thread overview]
Message-ID: <xmqq7fsjm0wb.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAN0XMOLhkTMWDr+eOsb5H8YiC1b7Nk0OKTSfi02ocr1unwFjfw@mail.gmail.com> (Ralf Thielow's message of "Fri, 8 May 2015 19:26:16 +0200")
Ralf Thielow <ralf.thielow@gmail.com> writes:
>> error(_("-m option was given for non-merge commit '%s'", ...);
>
> The %s can be placed to somewhere else in translations.
That is true for all the messages, and is something the l10n people
need to be aware of.
We've seen those who are careful to keep '%s' for longer strings
(e.g. end-user controlled ones strings) at the end for this exact
reason. I do not offhand recall if there were cases where we
committed one version that had %s in the middle and then fixed
later to change that message in a separate commit, but there were
cases where earlier messages with %s in the middle were fixed for
this exact reason in their rerolls.
next prev parent reply other threads:[~2015-05-08 17:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 16:53 [PATCH] sequencer.c: abbreviate hashs placed in the middle of messages Ralf Thielow
2015-05-08 17:10 ` Eric Sunshine
2015-05-08 17:20 ` Ralf Thielow
2015-05-08 17:20 ` Junio C Hamano
2015-05-08 17:26 ` Ralf Thielow
2015-05-08 17:31 ` Junio C Hamano [this message]
2015-05-08 17:58 ` Ralf Thielow
2015-05-08 18:42 ` Junio C Hamano
2015-05-08 19:56 ` Ralf Thielow
2015-05-08 20:24 ` Junio C Hamano
2015-05-08 20:57 ` Ralf Thielow
2015-05-10 9:05 ` Matthieu Moy
2015-05-10 19:17 ` Junio C Hamano
2015-05-10 19:36 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fsjm0wb.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ralf.thielow@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).