From: Junio C Hamano <gitster@pobox.com>
To: "Kyle J. McKay" <mackyle@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED
Date: Fri, 06 Feb 2015 12:05:28 -0800 [thread overview]
Message-ID: <xmqq7fvuhkl3.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <28F603A7-610B-4711-9D2F-CD9866C96A74@gmail.com> (Kyle J. McKay's message of "Fri, 6 Feb 2015 11:47:51 -0800")
"Kyle J. McKay" <mackyle@gmail.com> writes:
> Actually I just tested it. If we #undef it we could end up producing
> these:
>
> error: syntax error before DEPRECATED_ATTRIBUTE
>
> So I think it needs to stay #define'd to nothing to be safe in case
> anything later on ends up including stuff that uses it.
Doesn't the fact that your test failed indicates that it is not jsut
"to be safe in case" but is required for correctness?
The first hit for "MAC_OS_X_VERSION_MIN_REQUIRED" was this:
https://opensource.apple.com/source/CarbonHeaders/CarbonHeaders-18.1/AvailabilityMacros.h
which marks quite a many macros to that value. I do not know what
changes they make to openssl/*.h (which is included just after the
above header is included, but I would imagine that is where the
AVAILABLE_MAC_OS_X_VERSION_XXX_AND_LATER_BUT_DEPRECATED_IN_MAC_OS_VERSION_YYY
macros are checked and annoying warnings that are being squelched by
the previous change are given?
next prev parent reply other threads:[~2015-02-06 20:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 9:35 [PATCH] git-compat-util: do not step on MAC_OS_X_VERSION_MIN_REQUIRED Kyle J. McKay
2015-02-06 10:00 ` Eric Sunshine
2015-02-06 19:47 ` Kyle J. McKay
2015-02-06 20:05 ` Junio C Hamano [this message]
2015-02-06 20:43 ` Kyle J. McKay
2015-02-06 22:01 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq7fvuhkl3.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mackyle@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).