From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/7] builtin/commit-graph: some small cleanups
Date: Wed, 28 Oct 2026 14:28:58 -0700 [thread overview]
Message-ID: <xmqq8q3h7bvp.fsf@gitster.g> (raw)
In-Reply-To: <xmqqv76l7e48.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 28 Oct 2026 13:40:39 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> I read the first 4 steps and they all looked sensible. May come
> back to the remainder later this week if nobody beats me to it.
>
> Thanks.
As to the rest, quite honestly, [6/7] and [7/7] were "Meh", even
though I do not think they hurt [*].
All the rest looked good to me.
[Footnote]
* Unless these things are lifted out of bulitin/* hierarchy, there
is no strong reason to avoid relying on global variables or even
the_repository. Once we move things out of there to make them
truly reusable, these things start to matter, but until then...
next prev parent reply other threads:[~2026-10-28 21:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 11:57 [PATCH 0/7] builtin/commit-graph: some small cleanups Patrick Steinhardt
2026-10-28 11:57 ` [PATCH 1/7] builtin/commit-graph: rename subcommand functions Patrick Steinhardt
2026-10-28 11:57 ` [PATCH 2/7] builtin/commit-graph: drop declaration for `read_replace_refs` Patrick Steinhardt
2026-10-28 11:57 ` [PATCH 3/7] builtin/commit-graph: get rid of `the_repository` Patrick Steinhardt
2026-10-28 11:57 ` [PATCH 4/7] builtin/commit-graph: drop global "--object-dir=" switch Patrick Steinhardt
2026-10-28 11:57 ` [PATCH 5/7] builtin/commit-graph: simplify how we wire up common options Patrick Steinhardt
2026-10-28 11:57 ` [PATCH 6/7] builtin/commit-graph: de-globalize write options handling Patrick Steinhardt
2026-10-28 11:57 ` [PATCH 7/7] builtin/commit-graph: de-globalize " Patrick Steinhardt
2026-10-28 17:13 ` Mark C. Chu-Carroll
2026-10-28 20:40 ` [PATCH 0/7] builtin/commit-graph: some small cleanups Junio C Hamano
2026-10-28 21:28 ` Junio C Hamano [this message]
2026-10-29 12:55 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8q3h7bvp.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox