From: Junio C Hamano <gitster@pobox.com>
To: Hardik Kumar <hardikxk@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] t/t1467: use test_must_fail in place of NOT operator
Date: Wed, 28 Oct 2026 09:47:38 -0700 [thread overview]
Message-ID: <xmqq8q3hbwlx.fsf@gitster.g> (raw)
In-Reply-To: <20261028-refs-rename-test-fail-v2-1-505ca9558503@gmail.com> (Hardik Kumar's message of "Wed, 28 Oct 2026 15:53:45 +0530")
Hardik Kumar <hardikxk@gmail.com> writes:
> Replace the "not" (!) operator with `test_must_fail` for refs-rename
> test.
>
> The use of `test_must_fail` is preferred over not (!) operator because
> it ensures that the command fails gracefully. If the command crashes
> (e.g. a segfault) or is killed by a signal, the failure is handled
> correctly by `test_must_fail` which will fail the test whereas the `!`
> operator would silently accept the crash as an expected failure.
>
> Signed-off-by: Hardik Kumar <hardikxk@gmail.com>
> ---
> Changes in v2:
> - Refactor commit message
> - Link to v1: https://lore.kernel.org/r/20261028-refs-rename-test-fail-v1-1-b7458ca62149@gmail.com
> ---
> t/t1467-refs-rename.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Will queue. Thanks.
> diff --git a/t/t1467-refs-rename.sh b/t/t1467-refs-rename.sh
> index 2b28be75c8..b7d290d05b 100755
> --- a/t/t1467-refs-rename.sh
> +++ b/t/t1467-refs-rename.sh
> @@ -88,7 +88,7 @@ test_expect_success 'rename with symbolic ref fails' '
> A=$(git rev-parse A) &&
> git refs create refs/heads/target $A &&
> git symbolic-ref refs/heads/symref refs/heads/target &&
> - ! git refs rename refs/heads/symref refs/heads/renamed 2>err &&
> + test_must_fail git refs rename refs/heads/symref refs/heads/renamed 2>err &&
> test_grep "is a symbolic ref, .* not supported" err
> )
> '
>
> ---
> base-commit: 37b3475fb530c14109211faca33716a173db61ed
> change-id: 20261028-refs-rename-test-fail-ec7a8fa74e54
prev parent reply other threads:[~2026-10-28 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 10:23 [PATCH v2] t/t1467: use test_must_fail in place of NOT operator Hardik Kumar
2026-10-28 16:47 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8q3hbwlx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hardikxk@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox