Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Wolfgang Faust" <contrib-git@wolfgangfaust.com>
Cc: git@vger.kernel.org,  "Aditya Garg" <gargaditya08@live.com>
Subject: Re: [PATCH] imap-send: add --draft to set IMAP \Draft flag
Date: Tue, 01 Sep 2026 20:25:25 -0700	[thread overview]
Message-ID: <xmqq8q5kl4gq.fsf@gitster.g> (raw)
In-Reply-To: <761c3f1b-e280-48b1-a2ad-770b68be3434@slotpi01m90> (Wolfgang Faust's message of "Tue, 01 Sep 2026 17:13:21 -0700")

"Wolfgang Faust" <contrib-git@wolfgangfaust.com> writes:

> The documented purpose of imap-send is to upload draft emails for sending
> later, but it did not have any way to mark the messages as \Draft, so some
> email clients presented the result as an un-editable, un-sendable email
> even if it happened to be in a "Drafts" folder.

I agree that defaulting to '--no-draft' is a sensible design choice
to avoid breaking clients that have been working fine.

It would be helpful to know if e-mail clients that send messages
from the Drafts folder without the '\Draft' flag would misbehave if
they encounter messages marked as such.  Knowing this would help us
decide whether to flip the default to '--draft', while keeping
'--no-draft' as an escape hatch nobody is expected to use.

> +`--draft`::
> +`--no-draft`::
> +	Mark uploaded messages with the IMAP `\Draft` flag. The default is `--no-draft`.
> ++
> +With libcurl, `--draft` requires version 8.13.0 or later.
> +Older libcurl still uploads the message but cannot set the flag.

When compiled with older libcurl, would the command error out when
run with '--draft', or would it silently ignore the option?  I have
a mild preference for the former over the latter.  Issuing a warning
without erroring out is better than nothing, but people tend to
overlook warning messages.

Also you might want to consider adding a configuration variable,
perhaps?  I dunno.

Thanks.

  reply	other threads:[~2026-09-02  3:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02  0:13 [PATCH] imap-send: add --draft to set IMAP \Draft flag Wolfgang Faust
2026-09-02  3:25 ` Junio C Hamano [this message]
2026-09-02  4:28   ` Wolfgang Faust
2026-09-02 14:37     ` Junio C Hamano
2026-09-03  5:42 ` Aditya Garg
2026-09-03 13:42   ` Junio C Hamano
2026-09-03 14:37     ` Aditya Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8q5kl4gq.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=contrib-git@wolfgangfaust.com \
    --cc=gargaditya08@live.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox