Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Jamie Magee via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Jamie Magee <jamie.magee@gmail.com>
Subject: Re: [PATCH] t0213: skip ancestry tests under user-mode emulation
Date: Mon, 03 Aug 2026 13:59:25 -0700	[thread overview]
Message-ID: <xmqq8q6myl76.fsf@gitster.g> (raw)
In-Reply-To: <pull.2168.git.1783359242130.gitgitgadget@gmail.com> (Jamie Magee via GitGitGadget's message of "Mon, 06 Jul 2026 17:34:01 +0000")

"Jamie Magee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Jamie Magee <jamie.magee@gmail.com>
>
> The tests added in 3c8c638df6 (t0213: add trace2 cmd_ancestry tests,
> 2026-02-13) expect the cmd_ancestry event to name "test-tool" and
> "git". On Linux those names come from the "comm" field of
> /proc/<pid>/stat. Under user-mode emulation (e.g. qemu-user) /proc
> reports the emulator ("qemu-riscv64") instead, so the event is still
> emitted, the TRACE2_ANCESTRY probe enables the tests, and tests 2-5
> fail even though they pass on native riscv64.
>
> Require the probe to see "test-tool" in the ancestry of a test-tool
> spawned from test-tool, so the tests skip when the names are unreliable.
>
> Cc: Matthew John Cheetham <mjcheetham@outlook.com>
> Signed-off-by: Jamie Magee <jamie.magee@gmail.com>
> ---
>     t0213: skip ancestry tests under user-mode emulation

While nobody with similar environment that would benefit from this
change has stepped up since this patch was posted almost a month
ago (and I do not have such an environment to test it on, either),
this seems low impact enough to cause regressions in environments
where the change does not intend to affect (i.e., native environments
where process names are trustworthy).

So I am tempted to merge this down, only if it is to shrink the
number of in-flight topics I have to carry and watch out for
updates, as nobody seems to be motivated enough to recruit testers
or reviewers to move the topic forward.

Those who are not in the user-mode emulation environment and are
negatively affected because this patch drops TRACE2_ANCESTRY from
your envionment should block me with a real review on the patch,
preferrably with suggested improvements.

Thanks.

      parent reply	other threads:[~2026-08-03 20:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 17:34 [PATCH] t0213: skip ancestry tests under user-mode emulation Jamie Magee via GitGitGadget
2026-07-07  2:30 ` Junio C Hamano
2026-07-21 17:17   ` Junio C Hamano
2026-07-21 18:06 ` Weijie Yuan
2026-07-21 21:55   ` Junio C Hamano
2026-07-22  6:27     ` Weijie Yuan
2026-08-03 20:59 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8q6myl76.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=jamie.magee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox