From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b5-smtp.messagingengine.com (fout-b5-smtp.messagingengine.com [202.12.124.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D663E2F7ACA for ; Fri, 30 Jan 2026 16:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.148 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769790586; cv=none; b=U3FpwIZ+zIYrWrtq578NMS3OP+T7sLQEj9Rz1JKrRnkpOiZYRd0VSpuFDsgyxtQHGdxZVB57SdmOGQrf4hh3sZ8R/rSJWa96wFPf/YebBu9HA/Q0fNA8ZQkYQqZB2YvNNfRXBbz33Z1yU+L8LSvNAHRxxGJo+YbZLWZ2IWi6z3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769790586; c=relaxed/simple; bh=k+8NUopf8WHuN1WEnKVElx5Uj7THdo3usQ5OcJNGLpc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=SgNOeM/UU2rKzm4lLpOVatlgnnJY8dQvYuAmeOkuSlRpkVoHQDgDQh/n0NbsbQh3XOoa6EJ882KeXgOh8Xvg/cJ0+WMSWmsAJr1Psmhpqu46rnBd7C9jqx/jKo8XZNIrAYYanKp4RE/cbthfkLw7ItX4drh4v6t5pb1ZZ5Ybxl0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=X31m2Frg; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=M8iahx7k; arc=none smtp.client-ip=202.12.124.148 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="X31m2Frg"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="M8iahx7k" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfout.stl.internal (Postfix) with ESMTP id A6E251D000E8; Fri, 30 Jan 2026 11:29:43 -0500 (EST) Received: from phl-frontend-02 ([10.202.2.161]) by phl-compute-05.internal (MEProxy); Fri, 30 Jan 2026 11:29:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1769790583; x=1769876983; bh=k+8NUopf8W HuN1WEnKVElx5Uj7THdo3usQ5OcJNGLpc=; b=X31m2FrgH0b+Ld/amrSvfDmIoo RHGyCSA/hTUawOfpSBWVJ6RbqEf9bKVaOVTFZWWfax7oL+7QEEvEHE2V5+3ZMz7F cFjh79fazWgr/8UBSKJiWlKq3r+P0ghAETfkTssn10KEEPZZUvKTj4qkYscBlFVK KeNzpKebpYUohQ8y0461VRrkDDFK4rHb8vr0XgdpOiQFOqG0oCAtANqtVV3ltALq peWVJLJBEZ2wibNGseI9eWUh3DippmT1E3BIRkS2tXLWI12J2w0boCOpgM6wtRhs rJe+9MveLOFsR5+kFk/vibuRgT7dBUIVhhAqrs0JEskI7umUwj1rkyjOkTqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1769790583; x=1769876983; bh=k+8NUopf8WHuN1WEnKVElx5Uj7THdo3usQ5 OcJNGLpc=; b=M8iahx7kmPYZZFDv0FbDU5N8NyGNyVb4PtN0R7zDGS3SzhB91Xf KgbrZKirF886SeGFScu/T93gTZya50CIjBDpE4QIcgsJGrREuXPurzdPjMgwdQ14 xh3ypsmhsI8rEpD5Vpz+vX3U22y/AiAblAxCmqjbAVTkTGYMoBUOUmh2cCm9U/wa dMSDWnXPKqaquDQSNxdLP6cshJ3TQdM/WUw9g7nmB19mbRsxQKqpW7SxqQkxniFz xYjbaBdIKKNLYSXIgZ5DW2twg+euTCyfW4roZ+WWD58IrwrY5forgTFWEMN603np NBKKPxsxFGc90KIvq/1PM2NAE93ZEYIzrnQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdduieelhedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefujghffffkfgggtgesthdtredttdertdenucfhrhhomheplfhunhhiohcu vecujfgrmhgrnhhouceoghhithhsthgvrhesphhosghogidrtghomheqnecuggftrfgrth htvghrnhepfeevteetjeehueegffelvdetieevffeufeejleeuffetiefggfeftdfhfeei geeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepgh hithhsthgvrhesphhosghogidrtghomhdpnhgspghrtghpthhtohepledpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtoheprggsrhgrhhgrmhgruggvkhhunhhlvgehtdesghhmrg hilhdrtghomhdprhgtphhtthhopehgihhtsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhr tghpthhtohepphhssehpkhhsrdhimhdprhgtphhtthhopehphhhilhhlihhprdifohhoug duvdefsehgmhgrihhlrdgtohhmpdhrtghpthhtohepshiivgguvghrrdguvghvsehgmhgr ihhlrdgtohhmpdhrtghpthhtoheptghhrhhishhtihgrnhdrtghouhguvghrsehgmhgrih hlrdgtohhmpdhrtghpthhtohepkhhrihhsthhofhhfvghrhhgruhhgshgsrghkkhesfhgr shhtmhgrihhlrdgtohhmpdhrtghpthhtohepsggvnhdrkhhnohgslhgvsehgmhgrihhlrd gtohhmpdhrtghpthhtohepghhithhsthgvrhesphhosghogidrtghomh X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 30 Jan 2026 11:29:42 -0500 (EST) From: Junio C Hamano To: Samuel Abraham Cc: git@vger.kernel.org, Patrick Steinhardt , Phillip Wood , SZEDER =?utf-8?Q?G=C3=A1bor?= , Christian Couder , Kristoffer Haugsbakk , Ben Knoble Subject: Re: [PATCH v2 1/1] Allow reworking with a file after deciding on all its hunks In-Reply-To: (Samuel Abraham's message of "Fri, 30 Jan 2026 10:22:25 +0100") References: <9b21cb901ab14397af94b8ed2d09da1a9a6d862b.1769522219.git.abrahamadekunle50@gmail.com> Date: Fri, 30 Jan 2026 08:29:41 -0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Samuel Abraham writes: > Hello Junio, thank you for your review. > Here I explain my decision to move the "git apply" in patch_update_file() > to the caller. > > Does it sound like a valid reason to make the move? I am not sure, but as long as this is an optional feature, users can choose not to opt in if they do not like the new "all or none" semantics, I guess. Thanks.