Re: What's cooking in git.git (Jan 2026, #04)

[Junio C Hamano <gitster@pobox.com>]

Patrick Steinhardt <ps@pks.im> writes:

> On Tue, Jan 13, 2026 at 12:10:13PM -0800, Junio C Hamano wrote:
>> * ps/read-object-info-improvements (2026-01-12) 8 commits
>>  - packfile: drop repository parameter from `packed_object_info()`
>>  - packfile: skip unpacking object header for disk size requests
>>  - packfile: disentangle return value of `packed_object_info()`
>>  - packfile: always populate pack-specific info when reading object info
>>  - packfile: extend `is_delta` field to allow for "unknown" state
>>  - packfile: always declare object info to be OI_PACKED
>>  - object-file: always set OI_LOOSE when reading object info
>>  - Merge branch 'jc/object-read-stream-fix' into ps/read-object-info-improvements
>> 
>>  The object-info API has been cleaned up.
>> 
>>  Comments?
>>  source: <20260112-b4-pks-odb-read-object-info-improvements-v5-0-9a6124e95bf2@pks.im>
>
> I think this topic should be ready by now. The last iteration only added
> another test that catches a bug we recently started to hit in production
> systems, and the previous iterations all received reviews.
>
> I can try to loop in another set of reviewers though if you prefer.

For a topic like this with multiple iterations, I always revisit the
thread overview

https://lore.kernel.org/git/20260112-b4-pks-odb-read-object-info-improvements-v5-0-9a6124e95bf2@pks.im/

at lore, but it is hard to judge quickly if we have reached the
point of diminishing returns when the last few rounds got almost no
responses.

> I also noticed that the patch series at [1] is not in "seen" yet. Is
> that intentional or merely an oversight?
>
> Thanks!
>
> Patrick
>
> [1]: <20260105-pks-geometric-repack-with-promisors-v1-0-c4660573437e@pks.im>

It was more like "this topic saw a few responses, one saying the
thing is confusing, another saying the series is good up to one
point without mentioning anything about the later steps. perhaps it
is time to see an updated series, in which case my time is better
spent on other topics first".

Will take a look at them later today.  Thanks for pinging.