From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Meet Soni <meetsoni3017@gmail.com>,
git@vger.kernel.org, shejialuo@gmail.com
Subject: Re: [GSoC][PATCH 1/5] builtin/pack-refs: factor out core logic into a helper
Date: Tue, 02 Sep 2025 22:25:44 -0700 [thread overview]
Message-ID: <xmqq8qiwgl9j.fsf@gitster.g> (raw)
In-Reply-To: <aLbEWSHUotkmSiCq@pks.im> (Patrick Steinhardt's message of "Tue, 2 Sep 2025 12:18:01 +0200")
Patrick Steinhardt <ps@pks.im> writes:
>> builtin/pack-refs.c | 31 ++++++++++++++++++++-----------
>> pack-refs.h | 22 ++++++++++++++++++++++
>> 2 files changed, 42 insertions(+), 11 deletions(-)
>> create mode 100644 pack-refs.h
>
> Shouldn't that header live in "builtin/pack-refs.h"? Makes it way more
> obvious that it exposes functions from "builtin/pack-refs.c".
There shouldn't be any *.h files in builtin/. since the top-level
is where the library-ish reusable things live, so that they can
eventually be used by more than one *.c files in builtin/ and also
by other *.c files outside builtin.
next prev parent reply other threads:[~2025-09-03 5:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 7:36 [GSoC][PATCH 0/5] Add refs optimize subcommand Meet Soni
2025-08-26 7:36 ` [GSoC][PATCH 1/5] builtin/pack-refs: factor out core logic into a helper Meet Soni
2025-09-02 10:18 ` Patrick Steinhardt
2025-09-03 3:56 ` Meet Soni
2025-09-03 4:37 ` Patrick Steinhardt
2025-09-03 5:25 ` Junio C Hamano [this message]
2025-09-03 6:00 ` Patrick Steinhardt
2025-09-03 18:20 ` Junio C Hamano
2025-08-26 7:36 ` [GSoC][PATCH 2/5] doc: factor out common option Meet Soni
2025-08-26 7:36 ` [GSoC][PATCH 3/5] builtin/refs: add optimize subcommand Meet Soni
2025-09-02 10:18 ` Patrick Steinhardt
2025-08-26 7:36 ` [GSoC][PATCH 4/5] t0601: refactor tests to be shareable Meet Soni
2025-08-26 7:36 ` [GSoC][PATCH 5/5] t: add test for git refs optimize subcommand Meet Soni
2025-08-26 15:18 ` shejialuo
2025-08-31 6:20 ` Meet Soni
2025-09-02 10:18 ` Patrick Steinhardt
2025-09-03 3:58 ` Meet Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8qiwgl9j.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=meetsoni3017@gmail.com \
--cc=ps@pks.im \
--cc=shejialuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).