git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] t6137-*.sh: fix test failure on cygwin
Date: Fri, 08 Aug 2025 13:33:05 -0700	[thread overview]
Message-ID: <xmqq8qjth7um.fsf@gitster.g> (raw)
In-Reply-To: <5514f2fd-3307-42c8-97ac-bc2147a7ba41@ramsayjones.plus.com> (Ramsay Jones's message of "Fri, 8 Aug 2025 20:32:02 +0100")

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> [Hmm, I have just noticed that the 'skip_all' message could drop the
> redundant 'skipping: ' at the beginning - oh well! ;) ]

Yeah, I see skip_all="# SKIP $skip_all" in test-lib.sh

Let me squash the following in, to further match the message we give
when the test environment fails a test prerequisite.

 t/t6137-pathspec-wildcards-literal.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git c/t/t6137-pathspec-wildcards-literal.sh w/t/t6137-pathspec-wildcards-literal.sh
index 17a03085ef..e582378181 100755
--- c/t/t6137-pathspec-wildcards-literal.sh
+++ w/t/t6137-pathspec-wildcards-literal.sh
@@ -4,7 +4,7 @@ test_description='test wildcards and literals with git add/commit (subshell styl
 . ./test-lib.sh
 
 test_have_prereq BSLASHPSPEC || {
-	skip_all='skipping: needs BSLASHPSPEC (backslashes in pathspecs)'
+	skip_all='missing BSLASHPSPEC (backslashes in pathspecs)'
 	test_done
 }
 




  reply	other threads:[~2025-08-08 20:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 19:32 [PATCH] t6137-*.sh: fix test failure on cygwin Ramsay Jones
2025-08-08 20:33 ` Junio C Hamano [this message]
2025-08-09 11:50   ` Ramsay Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8qjth7um.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).