From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Git Mailing List <git@vger.kernel.org>, Patrick Steinhardt <ps@pks.im>
Subject: Re: issue with git submodules and a clone.defaultRemoteName different than origin?
Date: Fri, 06 Jun 2025 16:32:21 -0700 [thread overview]
Message-ID: <xmqq8qm41m62.fsf@gitster.g> (raw)
In-Reply-To: <bdf7e50f-aa65-4514-b147-9f7ebed147ab@intel.com> (Jacob Keller's message of "Fri, 6 Jun 2025 14:29:48 -0700")
Jacob Keller <jacob.e.keller@intel.com> writes:
> It looks like those end up in the "read_remotes_file" and
> "read_branches_file" functions which are deprecated, and planned to be
> removed in 3.0...
>
> Would patches to modify those to take a repository pointer in order to
> allow callers of read_config() to work properly with a submodule
> repository be acceptable?
The recent trend has been that it generally is very much welcomed to
fix such a code path that takes "repo" at an entry point but ends up
deep in its callchain to ignore it and use the_repository instead,
even without a potential use case to benefit from such a change.
You have a concrete use case, so I would suspect it is even better
than "acceptable". Patrick, what do you think?
Thanks.
next prev parent reply other threads:[~2025-06-06 23:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 23:06 issue with git submodules and a clone.defaultRemoteName different than origin? Jacob Keller
2025-06-03 23:42 ` Junio C Hamano
2025-06-04 17:18 ` Jacob Keller
2025-06-06 21:29 ` Jacob Keller
2025-06-06 23:32 ` Junio C Hamano [this message]
2025-06-07 5:43 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8qm41m62.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).