git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>,
	 Jeff King <peff@peff.net>,
	 Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	BERENDSEN Arnoud <arnoud.berendsen@soprasteria.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Cleaning up "contrib/"
Date: Tue, 13 May 2025 09:59:33 -0700	[thread overview]
Message-ID: <xmqq8qn0h2fe.fsf@gitster.g> (raw)
In-Reply-To: <aCMLgaWXr_gM8g3l@pks.im> (Patrick Steinhardt's message of "Tue, 13 May 2025 11:06:09 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> Yup. I think safe credential helpers should rather be moved into our
> official tree. This includes at least libsecret and osxkeychain.

Yes.  s|^contrib/|| should be sufficient for them.

> I'm not
> sure about the netrc one though -- it's unsafe by nature, and I'm not
> sure I would feel comfortable with shipping such a credential helper
> that is known-unsafe.

That depends.  It is a known-convenient helper that can often be
used in an unsafe way, but when used with GPG encrypted netrc files,
especially on a single user box that is reasonably secured, it is
unfair to call it known-unsafe, I would have to say.

Thanks.



  reply	other threads:[~2025-05-13 16:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-02 13:59 git svn clone failed BERENDSEN Arnoud
2025-05-04  8:19 ` Johannes Schindelin
2025-05-05  6:24   ` Cleaning up "contrib/" (was: git svn clone failed) Patrick Steinhardt
2025-05-05  7:36     ` Johannes Schindelin
2025-05-05  9:44       ` Patrick Steinhardt
2025-05-05 19:10     ` Cleaning up "contrib/" Junio C Hamano
2025-05-06  5:40       ` Patrick Steinhardt
2025-05-12 13:50         ` Jeff King
2025-05-13  0:13           ` brian m. carlson
2025-05-13  9:06             ` Patrick Steinhardt
2025-05-13 16:59               ` Junio C Hamano [this message]
2025-05-14 18:19             ` Jeff King
2025-05-14 20:05               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8qn0h2fe.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=arnoud.berendsen@soprasteria.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).