From: Junio C Hamano <gitster@pobox.com>
To: Aditya Garg <gargaditya08@live.com>
Cc: git@vger.kernel.org, M Hickford <mirth.hickford@gmail.com>,
Julian Swagemakers <julian@swagemakers.org>,
sandals@crustytoothpaste.net,
Eric Sunshine <sunshine@sunshineco.com>,
Zi Yao <ziyao@disroot.org>,
Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Subject: Re: [PATCH v5 0/3] Improve checks for valid_fqdn in send-email and update documentation
Date: Thu, 08 May 2025 07:56:41 -0700 [thread overview]
Message-ID: <xmqq8qn7882e.fsf@gitster.g> (raw)
In-Reply-To: <PN3PR01MB95974932FF37D9F24A7633C6B88BA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM> (Aditya Garg's message of "Thu, 8 May 2025 10:31:55 +0000")
Aditya Garg <gargaditya08@live.com> writes:
> This series of patches mainly has two changes:
>
> 1. Improve the checks for valid_fqdn in send-email to be more strict and
> compliant with RFC1035.
> 2. Update the documentation for send-email to include examples of using
> OAuth2.0 with Gmail and Outlook, as well as links to the credential
> helpers for these services.
>
> P.S. I have used `git-credential-outlook` linked in the second and third
> patch for this email!
;-)
> v5: - Simplify the regex in the first patch to check for valid FQDN.
> - Fix formatting in the second patch to make it more readable.
I didn't know if the $subdomain variable thing would actually work,
so it is great to see you took it and tested it.
Thanks for an update. Will queue.
prev parent reply other threads:[~2025-05-08 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-08 10:31 [PATCH v5 0/3] Improve checks for valid_fqdn in send-email and update documentation Aditya Garg
2025-05-08 10:31 ` [PATCH v5 1/3] send-mail: improve checks for valid_fqdn Aditya Garg
2025-05-08 10:31 ` [PATCH v5 2/3] docs: improve send-email documentation Aditya Garg
2025-05-08 10:31 ` [PATCH v5 3/3] docs: add credential helper for outlook and gmail in OAuth list of helpers Aditya Garg
2025-05-08 14:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8qn7882e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=gargaditya08@live.com \
--cc=git@vger.kernel.org \
--cc=julian@swagemakers.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=mirth.hickford@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).