Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Subject: [Bug?] "git show -s" still worries about renameLimit?
Date: Sun, 04 May 2025 01:00:16 -0700	[thread overview]
Message-ID: <xmqq8qncst4f.fsf@gitster.g> (raw)

$ git show -s | cat
warning: exhaustive rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 6123 and retry the command.
commit a3a9dd8be6b8767e690b014715aefa2ba39672e2 (HEAD -> master)
Author: Junio C Hamano <gitster@pobox.com>
Date:   Sat Apr 19 14:27:03 2025 -0700

    Something something something

As we have -M (rename detection) on by default these days, and this
particular commit has very many deletions and creations, if we were
asking to show some diff (not necessarily patch text output, but
just "--stat" or even "--raw") it is fair to warn about rename
detection being limited by diff.renameLimit.

But the command knows that with "-s" the user declined to show any
diff computation, so it feels wrong to even _count_ how many
diff_filepairs there are and comparing with the renameLimit, in
order to warn about busting the limit.


             reply	other threads:[~2025-05-04  8:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-04  8:00 Junio C Hamano [this message]
2025-05-04  8:27 ` [Bug?] "git show -s" still worries about renameLimit? Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8qncst4f.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox