From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Elijah Newren <newren@gmail.com>
Subject: Re: [PATCH 1/2] t5332-multi-pack-reuse.sh: demonstrate duplicate packing failure
Date: Thu, 14 Nov 2024 10:12:15 +0900 [thread overview]
Message-ID: <xmqq8qtm8vps.fsf@gitster.g> (raw)
In-Reply-To: <7a69cf84ae5b92d99e5777d4600270712424c4d7.1731518931.git.me@ttaylorr.com> (Taylor Blau's message of "Wed, 13 Nov 2024 12:32:55 -0500")
Taylor Blau <me@ttaylorr.com> writes:
> +test_expect_failure 'duplicate objects with verbatim reuse' '
> + git init duplicate-objects-verbatim &&
> + (
> + cd duplicate-objects-verbatim &&
> +
> + git config pack.allowPackReuse multi &&
> +
> + test_commit_bulk 64 &&
> +
> + # take the first object from the main pack...
> + git show-index <$(ls $packdir/pack-*.idx) >obj.raw &&
> + sort -nk1 <obj.raw | head -n1 | cut -d" " -f2 >in &&
> +
> + # ...and create a separate pack containing just that object
> + p="$(git pack-objects $packdir/pack <in)" &&
> + git show-index <$packdir/pack-$p.idx &&
Is this done so that "git show-index" fails when the .idx file fed
is malformed? Or is it a leftover debugging aid, where a human
developer was helped by eyeballing the contents of the .idx file in
human readable form? If the latter, do we perhaps want to "parse"
the output the same way in this test to validate our expectation?
> + git multi-pack-index write --bitmap --preferred-pack=pack-$p.idx &&
> +
> + test_pack_objects_reused_all 192 2
> + )
> +'
> +
> test_done
next prev parent reply other threads:[~2024-11-14 1:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 17:32 [PATCH 0/2] pack-objects: more brown-paper-bag multi-pack reuse fixes Taylor Blau
2024-11-13 17:32 ` [PATCH 1/2] t5332-multi-pack-reuse.sh: demonstrate duplicate packing failure Taylor Blau
2024-11-14 1:12 ` Junio C Hamano [this message]
2024-11-14 13:37 ` Taylor Blau
2024-11-13 17:32 ` [PATCH 2/2] pack-objects: only perform verbatim reuse on the preferred pack Taylor Blau
2024-11-14 0:25 ` Jeff King
2024-11-14 13:40 ` Taylor Blau
2024-11-15 9:57 ` Jeff King
2024-11-22 9:16 ` Kristoffer Haugsbakk
2024-11-14 13:42 ` [PATCH v2 0/2] pack-objects: more brown-paper-bag multi-pack reuse fixes Taylor Blau
2024-11-14 13:42 ` [PATCH v2 1/2] t5332-multi-pack-reuse.sh: demonstrate duplicate packing failure Taylor Blau
2024-11-14 13:42 ` [PATCH v2 2/2] pack-objects: only perform verbatim reuse on the preferred pack Taylor Blau
2024-11-22 4:44 ` Junio C Hamano
2024-11-22 8:33 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8qtm8vps.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).