git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Jeff King <peff@peff.net>,  git@vger.kernel.org
Subject: Re: [PATCH (v2.47 regression)] hash.h: set NEEDS_CLONE_HELPER_UNSAFE in fallback mode
Date: Thu, 03 Oct 2024 11:20:19 -0700	[thread overview]
Message-ID: <xmqq8qv5hwv0.fsf@gitster.g> (raw)
In-Reply-To: <Zv3r9FBd+Nog3wb7@nand.local> (Taylor Blau's message of "Wed, 2 Oct 2024 20:57:24 -0400")

Taylor Blau <me@ttaylorr.com> writes:

> On Wed, Oct 02, 2024 at 07:26:18PM -0400, Jeff King wrote:
>> diff --git a/hash.h b/hash.h
>> index f97f858307..756166ce5e 100644
>> --- a/hash.h
>> +++ b/hash.h
>> @@ -82,6 +82,9 @@
>>  #  ifdef platform_SHA1_Clone
>>  #    define platform_SHA1_Clone_unsafe platform_SHA1_Clone
>>  #  endif
>> +#  ifdef SHA1_NEEDS_CLONE_HELPER
>> +#    define SHA1_NEEDS_CLONE_HELPER_UNSAFE
>> +#  endif
>>  #endif
>
> Gah. I could have sworn I wrote something like this myself, but I must
> have dropped it or hallucinated writing it in the first place.
>
> Thanks for finding and fixing.

Yeah, thanks, all.

      reply	other threads:[~2024-10-03 18:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-02 23:26 [PATCH (v2.47 regression)] hash.h: set NEEDS_CLONE_HELPER_UNSAFE in fallback mode Jeff King
2024-10-03  0:13 ` brian m. carlson
2024-10-03  0:21   ` Jeff King
2024-10-03  1:00     ` Taylor Blau
2024-10-03  0:57 ` Taylor Blau
2024-10-03 18:20   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8qv5hwv0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).