git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Pavel Rappo <pavel.rappo@gmail.com>,
	 Elijah Newren <newren@gmail.com>,
	Git mailing list <git@vger.kernel.org>
Subject: Re: How to turn off rename detection for cherry-pick?
Date: Fri, 30 Aug 2024 09:14:31 -0700	[thread overview]
Message-ID: <xmqq8qwet2c8.fsf@gitster.g> (raw)
In-Reply-To: <20240830003147.GA450797@coredump.intra.peff.net> (Jeff King's message of "Thu, 29 Aug 2024 20:31:47 -0400")

Jeff King <peff@peff.net> writes:

> though I'm not sure how DIFF_DETECT_COPIES should be handled
> ("recursive" silently downgrades it to DIFF_DETECT_RENAME).

I somehow suspect that we would want to go there to avoid
overloading ourselves (and end-users) with conceptual complexity.

If we detect that the file the side branch modified was copied to
create multiple files on our side (with or without modification on
our end), where would we want to reapply their changes to?  To the
original file only?  To all copies?  The same story goes for the
opposite direction.  How should possibly different changes they made
to their copies be merged back to the sole original file we have
(which we may or may not have modified)?  What if the both sides
made copies of the same file, and now we need to shuffle NxM
combination of changes?  I would expect it would be a whole can of
worms, which we _may_ be able to define concrete rules how we would
handle each of these cases but we may have a hard time to explain in
simple terms to end-users.



  parent reply	other threads:[~2024-08-30 16:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26 11:09 How to turn off rename detection for cherry-pick? Pavel Rappo
2024-08-29  8:47 ` Pavel Rappo
2024-08-29 21:43   ` Jeff King
2024-08-29 23:12     ` Pavel Rappo
2024-08-30  0:31       ` Jeff King
2024-08-30 10:35         ` Pavel Rappo
2024-08-30 14:33         ` Elijah Newren
2024-08-30 16:49           ` Junio C Hamano
2024-08-30 16:14         ` Junio C Hamano [this message]
2024-08-30 17:17           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8qwet2c8.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    --cc=pavel.rappo@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).