git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ariel Cabello Mateos <080ariel@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] gitweb: rss/atom change published/updated date to committer date
Date: Sat, 06 Jul 2024 15:01:00 -0700	[thread overview]
Message-ID: <xmqq8qyenpsz.fsf@gitster.g> (raw)
In-Reply-To: <CALRJROB7gGWok-YPGTjPe+TXkU5Y_MhqcPSiCGoPDzJ=WGHoKA@mail.gmail.com> (Ariel Cabello Mateos's message of "Sat, 6 Jul 2024 16:16:15 +0000")

Ariel Cabello Mateos <080ariel@gmail.com> writes:

> Currently the value used is the author date. Change it to the
> committer date that betters reflect the "published/updated" definition
> and makes rss/atom feeds more linear. Gitlab/Github rss/atom feeds use
> the committer date.
>
> The committer date is already used to determine if more items should be fetched.
>
> Signed-off-by: Jesús Ariel Cabello Mateos <080ariel@gmail.com>
> ---
> Changes since v1:
> - Typo fix in the commit message.
> - Semantic fixes in the commit message.

error: corrupt patch at line 20



> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index ccd14e0e30..0ef5707557 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -8329,7 +8329,7 @@ sub git_feed {
>                 if (($i >= 20) && ((time - $co{'author_epoch'}) > 48*60*60)) {
>                         last;
>                 }
> -               my %cd = parse_date($co{'author_epoch'}
> , $co{'author_tz'});
> +               my %cd = parse_date($co{'committer_epoch'},
> $co{'committer_tz'});
>
>                 # get list of changed files
>                 open my $fd, "-|", git_cmd(), "diff-tree", '-r', @diff_opts,

  reply	other threads:[~2024-07-06 22:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-04 16:45 [PATCH] gitweb: rss/atom change published/updated date to committed date Jesús Ariel Cabello Mateos
2024-07-06  6:08 ` Junio C Hamano
2024-07-06 16:16 ` [PATCH v2] gitweb: rss/atom change published/updated date to committer date Ariel Cabello Mateos
2024-07-06 22:01   ` Junio C Hamano [this message]
2024-07-06 22:35     ` Junio C Hamano
2024-07-07 18:48 ` [PATCH v3] " Jesús Ariel Cabello Mateos
2024-07-08 11:11   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqq8qyenpsz.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=080ariel@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).