From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org, code@khaugsbakk.name
Subject: Re: [PATCH v3] send-email: make it easy to discern the messages for each patch
Date: Fri, 05 Apr 2024 18:12:27 -0700 [thread overview]
Message-ID: <xmqq8r1rs39g.fsf@gitster.g> (raw)
In-Reply-To: <e3212c0a4ad331685c68c13afcdbced20982ab32.1712364420.git.dsimic@manjaro.org> (Dragan Simic's message of "Sat, 6 Apr 2024 02:50:18 +0200")
Dragan Simic <dsimic@manjaro.org> writes:
> As the final touch, make the above-mentioned prompt emitted without using
> underlined text, which also applies to any other produced prompts, which made
> them somewhat hard on the eyes, especially because the prompt's tailing space
> character was also underlined.
Don't do this, or at least don't do this in the same patch.
Another lesson to learn: resist temptation to grow the scope of the
topic. Especially with ascetics, your preference may not be shared
by other users, which would easily hold up the main part of the
patch you wanted to improve and the reviewers have already spent
effort on to polish to be ready. Also are you sure in everybody's
environment that ->ornaments() call is available and effective?
That is another thing that can hold up the rest of this change.
Don't waste your effort so far and build it as a follow-up patch
and do so after the dust settles.
Thanks.
next prev parent reply other threads:[~2024-04-06 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 0:50 [PATCH v3] send-email: make it easy to discern the messages for each patch Dragan Simic
2024-04-06 1:12 ` Junio C Hamano [this message]
2024-04-06 1:17 ` Dragan Simic
2024-04-06 1:30 ` Junio C Hamano
2024-04-06 1:34 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8r1rs39g.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).