From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Harmen Stoppels via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Harmen Stoppels <me@harmenstoppels.nl>
Subject: Re: [PATCH] rebase: make warning less passive aggressive
Date: Wed, 21 Feb 2024 09:31:44 -0800 [thread overview]
Message-ID: <xmqq8r3dpvun.fsf@gitster.g> (raw)
In-Reply-To: <ZdWiyYhKAB3_P6_k@tanuki> (Patrick Steinhardt's message of "Wed, 21 Feb 2024 08:14:17 +0100")
Patrick Steinhardt <ps@pks.im> writes:
>> if (options.action != ACTION_NONE && !in_progress)
>> - die(_("No rebase in progress?"));
>> + die(_("No rebase in progress"));
>
> While we're at it changing this message, do we also want to convert it
> to start with a lower-case letter so that it aligns with our error
> message style?
Good eyes. Thanks for a good suggestion.
next prev parent reply other threads:[~2024-02-21 17:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 15:23 [PATCH] rebase: make warning less passive aggressive Harmen Stoppels via GitGitGadget
2024-02-20 17:29 ` Junio C Hamano
2024-02-21 17:38 ` Michal Suchánek
2024-02-21 17:56 ` Junio C Hamano
2024-02-21 18:02 ` Junio C Hamano
2024-02-21 18:30 ` Michal Suchánek
2024-02-21 22:05 ` Jean-Noël AVILA
2024-02-21 22:46 ` Junio C Hamano
2024-02-22 1:43 ` Junio C Hamano
2024-02-22 10:01 ` Jean-Noël AVILA
2024-02-22 11:04 ` Michal Suchánek
2024-02-22 16:46 ` Junio C Hamano
2024-02-21 7:14 ` Patrick Steinhardt
2024-02-21 17:31 ` Junio C Hamano [this message]
2024-02-21 17:38 ` [PATCH v2] " Harmen Stoppels via GitGitGadget
2024-02-22 8:15 ` Patrick Steinhardt
2024-02-22 10:53 ` Kristoffer Haugsbakk
2024-02-22 17:00 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq8r3dpvun.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@harmenstoppels.nl \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).